Citizen names should be unique
marvin-bitterlich opened this issue · 4 comments
We have more then enough name combinations already to achieve this.
Each citizens name should be unique in his colony. So on spawn we check all other citizens and discard names that already exist. Since we have a <1% hit rate, this runs in Ω(2).
We should also allow admins/owners to specifiy citizen commands via the citizens name (now that that is unique) and offer autocompletion for it
Would love the idea of having more direct control over the citizens, and I think the uniqueness check is definitely a must.
I've added a tonne more names to my game; for anyone interested? I like the fact that the surname list is fairly short as it makes it look like families are growing.
names {
# Female First Names
S:femaleFirstNames <
Mary
Patricia
Linda
Barbara
Elizabeth
Jennifer
Maria
Susan
Margaret
Dorothy
Lisa
Nancy
Karen
Betty
Helen
Natasha
Sophia
Emma
Olivia
Ava
Mia
Isabella
Riley
Aria
Zoe
Charlotte
Lily
Layla
Amelia
Emily
Madelyn
Aubrey
Adalyn
Madison
Chloe
Harper
Abigail
Aaliyah
Avery
Evelyn
Kaylee
Ella
Ellie
Scarlett
Arianna
Hailey
Nora
Addison
Brooklyn
Hannah
Mila
Leah
Elizabeth
Sarah
Eliana
Mackenzie
Peyton
Maria
Grace
Adeline
Elena
Anna
Victoria
Camilla
Lillian
Natalie
Isabelle
Skyler
Maya
Lucy
Lila
Audrey
Makayla
Penelope
Claire
Kennedy
Paisley
Savannah
Alaina
Gabriella
Violet
Kylie
Charlie
Stella
Allison
Liliana
Eva
Callie
Kinsley
Reagan
Sophie
Alyssa
Alice
Caroline
Aurora
Eleanor
Juliana
Annabelle
Emilia
Sadie
Bella
Julia
Keira
Bailey
Hazel
Jocelyn
London
Samantha
Vivian
Gianna
Alexandra
Cora
Melanie
Everly
Jordyn
Luna
>
# Last Names
S:lastNames <
Smith
Johnson
Jones
Williams
Brown
Miller
Wilson
Taylor
Jackson
White
Harris
Robinson
Clark
Wallgreen
Allen
Mardle
Fletcher
>
# Male First Names
S:maleFirstNames <
Jim
John
James
Robert
Thomas
Michael
William
David
Richard
Charles
Joseph
Christopher
Paul
Mark
George
Steven
Peter
Henrik
Rory
Jackson
Aiden
Lucas
Liam
Noah
Ethan
Mason
Caden
Oliver
Elijah
Grayson
Jacob
Michael
Benjamin
Carter
James
Jayden
Logan
Alexander
Caleb
Ryan
Luke
Daniel
Jack
William
Owen
Gabriel
Matthew
Connor
Jayce
Isaac
Sebastian
Henry
Muhammad
Cameron
Wyatt
Dylan
Nathan
Nicholas
Julian
Eli
Levi
Isaiah
Landon
David
Christian
Andrew
Brayden
John
Lincoln
Samuel
Joseph
Hunter
Joshua
Mateo
Dominic
Adam
Leo
Ian
Josiah
Anthony
Colton
Max
Thomas
Evan
Nolan
Aaron
Carson
Christopher
Hudson
Cooper
Adrian
Jonathan
Jason
Charlie
Miles
Jeremiah
Gavin
Asher
Austin
Ezra
Chase
Alex
Xavier
Jordan
Tristan
Easton
Zachary
Parker
Bryson
Tyler
Camden
Damian
Declan
Elliot
Elias
Cole
Harrison
Zane
Kai
>
}
@nekatu Would be awesome if you could make a pull request with the changed names :)
Look here for how our default configuration gets created: https://github.com/Minecolonies/minecolonies/blob/develop/src/main/java/com/minecolonies/coremod/configuration/Configurations.java
I'll add the names and make the names unique!
Thanks @nekatu !