MineColonies

MineColonies

53M Downloads

[518-alpha] CitizenData.View IndexOutOfBounds crashing clients

kreezxil opened this issue ยท 0 comments

commented

Minecolonies version

Version: 0.10.518-ALPHA

Expected behavior

not crash

Was not even interacting with minecolonies, altho i'm one of its officers. The server did something and everyone connected that is an officer of the colony received this lock up in the client. The client didn't crash, it just froze so there is no client crash report.

Steps

There are no real steps, except to play World of Dragons - A New Age and wait for it to happen.

latest.log excerpt

[10:06:19] [Client thread/ERROR]: A CitizenData.View for #5 has thrown an exception during loading, its state cannot be restored. Report this to the mod author
java.lang.IndexOutOfBoundsException: readerIndex(13) + length(1) exceeds writerIndex(13): PooledUnsafeDirectByteBuf(ridx: 13, widx: 13, cap: 13)
	at io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1405) ~[netty-all-4.1.25.Final.jar:4.1.25.Final]
	at io.netty.buffer.AbstractByteBuf.readByte(AbstractByteBuf.java:707) ~[netty-all-4.1.25.Final.jar:4.1.25.Final]
	at net.minecraft.network.PacketBuffer.readByte(PacketBuffer.java:728) ~[?:?]
	at net.minecraft.network.PacketBuffer.func_150792_a(PacketBuffer.java:173) ~[?:?]
	at net.minecraft.network.PacketBuffer.func_150789_c(PacketBuffer.java:313) ~[?:?]
	at com.minecolonies.coremod.colony.CitizenDataView.deserialize(CitizenDataView.java:386) ~[?:0.10.518-ALPHA]
	at com.minecolonies.coremod.colony.CitizenDataManager.createFromNetworkData(CitizenDataManager.java:32) [?:0.10.518-ALPHA]
	at com.minecolonies.coremod.colony.ColonyView.handleColonyViewCitizensMessage(ColonyView.java:759) [?:0.10.518-ALPHA]
	at com.minecolonies.coremod.colony.ColonyManager.handleColonyViewCitizensMessage(ColonyManager.java:1030) [?:0.10.518-ALPHA]
	at com.minecolonies.coremod.network.messages.ColonyViewCitizenViewMessage.onExecute(ColonyViewCitizenViewMessage.java:82) [?:0.10.518-ALPHA]
	at com.minecolonies.coremod.network.NetworkChannel.lambda$null$3(NetworkChannel.java:171) [?:0.10.518-ALPHA]
	at com.minecolonies.coremod.network.NetworkChannel$$Lambda$8361/1376525727.run(Unknown Source) [?:0.10.518-ALPHA]
	at net.minecraftforge.fml.network.NetworkEvent$Context.enqueueWork(NetworkEvent.java:215) [?:?]
	at com.minecolonies.coremod.network.NetworkChannel.lambda$registerMessage$4(NetworkChannel.java:171) [?:0.10.518-ALPHA]
	at com.minecolonies.coremod.network.NetworkChannel$$Lambda$5992/1125096104.accept(Unknown Source) [?:0.10.518-ALPHA]
	at net.minecraftforge.fml.network.simple.IndexedMessageCodec.lambda$tryDecode$3(IndexedMessageCodec.java:124) [?:?]
	at net.minecraftforge.fml.network.simple.IndexedMessageCodec$$Lambda$7876/732685621.accept(Unknown Source) [?:?]
	at java.util.Optional.ifPresent(Optional.java:159) [?:1.8.0_51]
	at net.minecraftforge.fml.network.simple.IndexedMessageCodec.tryDecode(IndexedMessageCodec.java:124) [?:?]
	at net.minecraftforge.fml.network.simple.IndexedMessageCodec.consume(IndexedMessageCodec.java:157) [?:?]
	at net.minecraftforge.fml.network.simple.SimpleChannel.networkEventListener(SimpleChannel.java:79) [?:?]
	at net.minecraftforge.fml.network.simple.SimpleChannel$$Lambda$2043/2012884428.accept(Unknown Source) [?:?]
	at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:212) [eventbus-1.0.0-service.jar:?]
	at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:204) [eventbus-1.0.0-service.jar:?]
	at net.minecraftforge.eventbus.EventBus$$Lambda$2045/883782927.invoke(Unknown Source) [eventbus-1.0.0-service.jar:?]
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:258) [eventbus-1.0.0-service.jar:?]
	at net.minecraftforge.fml.network.NetworkInstance.dispatch(NetworkInstance.java:84) [?:?]
	at net.minecraftforge.fml.network.NetworkHooks.lambda$onCustomPayload$0(NetworkHooks.java:74) [?:?]
	at net.minecraftforge.fml.network.NetworkHooks$$Lambda$7864/1713047644.apply(Unknown Source) [?:?]
	at java.util.Optional.map(Optional.java:215) [?:1.8.0_51]
	at net.minecraftforge.fml.network.NetworkHooks.onCustomPayload(NetworkHooks.java:74) [?:?]
	at net.minecraft.client.network.play.ClientPlayNetHandler.func_147240_a(ClientPlayNetHandler.java:1783) [?:?]
	at net.minecraft.network.play.server.SCustomPayloadPlayPacket.func_148833_a(SCustomPayloadPlayPacket.java:55) [?:?]
	at net.minecraft.network.play.server.SCustomPayloadPlayPacket.func_148833_a(SCustomPayloadPlayPacket.java:11) [?:?]
	at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) [?:?]
	at net.minecraft.network.PacketThreadUtil$$Lambda$7929/1216936512.run(Unknown Source) [?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) [?:?]
	at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) [?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) [?:?]
	at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) [?:?]
	at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:861) [?:?]
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:384) [?:?]
	at net.minecraft.client.main.Main.main(SourceFile:155) [?:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
	at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:56) [forge-1.14.4-28.1.85.jar:28.1]
	at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$400/1190857779.call(Unknown Source) [forge-1.14.4-28.1.85.jar:28.1]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-4.1.0.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-4.1.0.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-4.1.0.jar:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-4.1.0.jar:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-4.1.0.jar:?]

Attached Latest.log

https://drive.google.com/open?id=1F3u-vzmWy-2_dg4tYx8LMSaXfaZ419xZ <-- 50+mb it's filled with the excerpt is why