MineColonies

MineColonies

Mods
53M Downloads

[Code enhancement] De-enumize network messages

Nightenom opened this issue ยท 1 comments

commented

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.16.2
  • MineColonies Version: pre/1.16.2 branch :)
  • Structurize Version: irrelevant

Problem description

We should split messages which use enums to standalone messages. Network channel is already int based codec, no need to double it. Also said messages often have switch based onExecute which is just nothing but mess.

Notes or related things

Viewers

  • Add a thumbs-up to the issue to vote for it. This helps the request become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

Currently offending messages are ChangeFreeToInteractBlockMessage and BuildRequestMessage which is few less than back then. Both are relatively small ones, but still could use abstraction and better class naming