MineColonies

MineColonies

53M Downloads

The chunks claimed message which was introduced by #5734 is displayed even if no actual expansion happens

MatthiasMann opened this issue ยท 3 comments

commented

Prerequisites

  • [x ] I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • [ x] I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • [ x] I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.15.2
  • MineColonies Version: minecolonies-0.13.234-ALPHA-universal
  • Structurize Version: structurize-0.13.64-ALPHA
  • Related Mods and their Versions:

Expected behavior

That the message is only displayed when new chunks have been claimed by my colony.

Actual behavior

[07Sep2020 23:26:17.819] [Server thread/INFO] [minecolonies/]: WorkOrderBuild at location BlockPos{x=899, y=70, z=51} is using schematics/fortress/shepherd1 instead of schematics/fortress/shepherd1
[07Sep2020 23:26:17.821] [Server thread/INFO] [minecolonies/]: WorkOrderBuild at location BlockPos{x=899, y=70, z=51} is using schematics/fortress/shepherd2 instead of schematics/fortress/shepherd2
[07Sep2020 23:26:17.848] [Render thread/INFO] [net.minecraft.client.gui.NewChatGui/]: [CHAT] 1 chunks around shepherd have been claimed for your colony.
[07Sep2020 23:26:17.848] [Render thread/INFO] [net.minecraft.client.gui.NewChatGui/]: [CHAT] Build Request Created!
[07Sep2020 23:26:35.543] [Render thread/INFO] [net.minecraft.client.gui.NewChatGui/]: [CHAT] Builder Luna A. Johnson started building shepherd2.

...

[07Sep2020 23:35:24.636] [Server thread/INFO] [minecolonies/]: WorkOrderBuild at location BlockPos{x=899, y=70, z=51} is using schematics/fortress/shepherd2 instead of schematics/fortress/shepherd2
[07Sep2020 23:35:24.640] [Render thread/INFO] [net.minecraft.client.gui.NewChatGui/]: [CHAT] Builder Luna A. Johnson finished building shepherd2.
[07Sep2020 23:35:24.640] [Render thread/INFO] [net.minecraft.client.gui.NewChatGui/]: [CHAT] 1 chunks around shepherd have been claimed for your colony.

The shepard is placed directly next to the townhall (fortress style) and surrounded by a citizen3 and a cowherder3 and further away (2 chunks) is also a guardtower2.

Steps to reproduce the issue

  1. Upgrade or build a normal hut (no guard tower or barracks which have a big claim area) in a place surrounded by other buildings with big claim areas
  2. See the chunks claimed message appear both at the start of the build and when it finished even so these chunks have long since been claimed and even been build on before.

Logs

I can upload the logs when required - but in this case I don't think it's needed as every building job has the same output as these above.

Notes


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

I don't see a problem with this. This just tells you how many chunks a building claims around it. If those chunks are claimed or not, that's useful information or not?

commented

Well - the text '1 chunks around X have been claimed' sounds like something has changed - if it would be 'X claims 1 chunks around itself' maybe.

But personally I would think it's more useful to know if the claimed chunks have actually been changed by a building.

commented

I agree. If the chunks are already claimed, it doesn't make sense for the message to announce that they've been claimed-you already know that!