[2829] Miner still on strike [$5]
kreezxil opened this issue · 28 comments
In build 2829, miner still stands at his box not saying or do something. I used the new
/mc citizens citizenInfo command to discover he was stuck in a need item task. So I started added all of the tools from wood to diamond for shovels, axes, and pickaxes, still nothing, then I started giving him mats from oak planks up to torches and cobblestone. He grabbed cobblestone and ladders and went to work. He's still not saying anything in server console or in game chat. But at least you can get him to work if use your Psychic mind reading skills on him.
On the command, can you also make it so that we can access the citizenInfo via citizen ID as well, as typing their full name seems a little unnecessary especially when the list command gives their ids. Keep the full name thing tho.
Did you help close this issue? Go claim the $5 bounty on Bountysource.
The miner not saying stuff he needs is a long time bug we still have not fixed (and I am honestly clueless xD)
The colony info command should accept ids. It was more a feature to also accept names xD
it's /mc citizens info colonyId citizenId
2017-02-13 13:31 GMT-02:00 kreezxil <[email protected]>:
… About everything I'll have to recheck the builder later
-----Original Message-----
From: "Raycoms" ***@***.***>
Sent: 2/13/2017 8:55 AM
To: "Minecolonies/minecolonies" ***@***.***>
Cc: "kreezxil" ***@***.***>; "Author" ***@***.***>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
(#584)
Okay it's now only the miner who is quiet or miner and builder?
And is he only quiet about cobble? Or about all blocks, or about all
blocks and tools?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9yz2pq-ydnTWS2FPJ56ISDdzjNUW9ks5rcHdogaJpZM4L-t7c>
.
Ok, that seems a bit much, from the colony owner perspective I did, /mc citizens citizenInfo Nathan T. Inman ... And it worked. Help probably should be more verbose then.
-----Original Message-----
From: "Raycoms" <[email protected]>
Sent: 2/13/2017 10:23 AM
To: "Minecolonies/minecolonies" <[email protected]>
Cc: "kreezxil" <[email protected]>; "Author" <[email protected]>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike (#584)
it's /mc citizens info colonyId citizenId
2017-02-13 13:31 GMT-02:00 kreezxil <[email protected]>:
About everything I'll have to recheck the builder later
-----Original Message-----
From: "Raycoms" ***@***.***>
Sent: 2/13/2017 8:55 AM
To: "Minecolonies/minecolonies" ***@***.***>
Cc: "kreezxil" ***@***.***>; "Author" ***@***.***>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
(#584)
Okay it's now only the miner who is quiet or miner and builder?
And is he only quiet about cobble? Or about all blocks, or about all
blocks and tools?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9yz2pq-ydnTWS2FPJ56ISDdzjNUW9ks5rcHdogaJpZM4L-t7c>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
If it is your own colony /mc citizens info citizenId should work as well.
I'll test if it works.
2017-02-13 14:39 GMT-02:00 kreezxil <[email protected]>:
… Ok, that seems a bit much, from the colony owner perspective I did, /mc
citizens citizenInfo Nathan T. Inman ... And it worked. Help probably
should be more verbose then.
-----Original Message-----
From: "Raycoms" ***@***.***>
Sent: 2/13/2017 10:23 AM
To: "Minecolonies/minecolonies" ***@***.***>
Cc: "kreezxil" ***@***.***>; "Author" ***@***.***>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
(#584)
it's /mc citizens info colonyId citizenId
2017-02-13 13:31 GMT-02:00 kreezxil ***@***.***>:
> About everything I'll have to recheck the builder later
>
> -----Original Message-----
> From: "Raycoms" ***@***.***>
> Sent: 2/13/2017 8:55 AM
> To: "Minecolonies/minecolonies" ***@***.***>
> Cc: "kreezxil" ***@***.***>; "Author" ***@***.***
>
> Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
> (#584)
>
> Okay it's now only the miner who is quiet or miner and builder?
> And is he only quiet about cobble? Or about all blocks, or about all
> blocks and tools?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#584 (comment)
279425299>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AGI9yz2pq-
ydnTWS2FPJ56ISDdzjNUW9ks5rcHdogaJpZM4L-t7c>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9y6lFCTUvoCAJv8Lz5BuuQlhScZJYks5rcIc3gaJpZM4L-t7c>
.
OKay I fixed it. The next update will allow that.
2017-02-13 14:52 GMT-02:00 Ray Neiheiser <[email protected]>:
… If it is your own colony /mc citizens info citizenId should work as well.
I'll test if it works.
2017-02-13 14:39 GMT-02:00 kreezxil ***@***.***>:
> Ok, that seems a bit much, from the colony owner perspective I did, /mc
> citizens citizenInfo Nathan T. Inman ... And it worked. Help probably
> should be more verbose then.
>
> -----Original Message-----
> From: "Raycoms" ***@***.***>
> Sent: 2/13/2017 10:23 AM
> To: "Minecolonies/minecolonies" ***@***.***>
> Cc: "kreezxil" ***@***.***>; "Author" ***@***.***>
> Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
> (#584)
>
> it's /mc citizens info colonyId citizenId
>
> 2017-02-13 13:31 GMT-02:00 kreezxil ***@***.***>:
>
> > About everything I'll have to recheck the builder later
> >
> > -----Original Message-----
> > From: "Raycoms" ***@***.***>
> > Sent: 2/13/2017 8:55 AM
> > To: "Minecolonies/minecolonies" ***@***.***>
> > Cc: "kreezxil" ***@***.***>; "Author" <
> ***@***.***>
> > Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
> > (#584)
> >
> > Okay it's now only the miner who is quiet or miner and builder?
> > And is he only quiet about cobble? Or about all blocks, or about all
> > blocks and tools?
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub, or mute the thread.
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <#584
> issuecomment-279425299>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AGI9yz2pq-ydnTWS2FPJ56ISDdzjNUW9ks5rcHdogaJpZM4L-t7c>
> > .
>
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#584 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AGI9y6lFCTUvoCAJv8Lz5BuuQlhScZJYks5rcIc3gaJpZM4L-t7c>
> .
>
I just checked it on build 2837 and the builder and the miner both don't say anything, at least you can play psychic roulette with them and sort of figure it out, like 10 versions ago.
Okay it's now only the miner who is quiet or miner and builder?
And is he only quiet about cobble? Or about all blocks, or about all blocks and tools?
It ignored me when I tried the id
…-----Original Message-----
From: "Raycoms" <[email protected]>
Sent: 2/13/2017 8:49 AM
To: "Minecolonies/minecolonies" <[email protected]>
Cc: "kreezxil" <[email protected]>; "Author" <[email protected]>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike (#584)
Doesn't it work via citizen id? It should work via id.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
About everything I'll have to recheck the builder later
…-----Original Message-----
From: "Raycoms" <[email protected]>
Sent: 2/13/2017 8:55 AM
To: "Minecolonies/minecolonies" <[email protected]>
Cc: "kreezxil" <[email protected]>; "Author" <[email protected]>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike (#584)
Okay it's now only the miner who is quiet or miner and builder?
And is he only quiet about cobble? Or about all blocks, or about all blocks and tools?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
@kreezxil all actual errors get violently thrown at the console, the problem are bugs not errors ;)
I was thinking that you should have an option if not already (then what is it), to make the client and server consoles very verbose to help with debugging. For instance, I have the sneaky feeling that you have a lot of Try-Catch code to intercept error conditions and then move on with things. If there were an option to stop all this error capturing and just let it pass through to the console that might be most helpful.
I'm all for it, because that last request would mean that I wouldn't be running any companion mods, as running such verbose level of data would be as crippling. However, I think that it would be instrumental in helping to solve this current state of issues where no errors are being reported to the console, ie because of "logic" bugs.
Seems you know what I meant, is there a way to turn that on for your "bugs"?
…-----Original Message-----
From: "Marvin Hofmann" <[email protected]>
Sent: 2/14/2017 11:06 AM
To: "Minecolonies/minecolonies" <[email protected]>
Cc: "kreezxil" <[email protected]>; "Mention" <[email protected]>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike (#584)
@kreezxil all actual errors get violently thrown at the console, the problem are bugs not errors ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
bugs is something which does something we don't want without throwing
errors messages and are therefore quite hidden.
Errors can be easily be found because we always log them.
2017-02-14 17:59 GMT-02:00 kreezxil <[email protected]>:
… Seems you know what I meant, is there a way to turn that on for your
"bugs"?
-----Original Message-----
From: "Marvin Hofmann" ***@***.***>
Sent: 2/14/2017 11:06 AM
To: "Minecolonies/minecolonies" ***@***.***>
Cc: "kreezxil" ***@***.***>; "Mention" ***@***.***
>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
(#584)
@kreezxil all actual errors get violently thrown at the console, the
problem are bugs not errors ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9y-lnWKmhcrQIY0Rmnba7XH8n-p41ks5rcgeagaJpZM4L-t7c>
.
Then do you have poured can you make a debug build that prints to console before and after suspect events, this would help is to help you by finding out what has stopped firing.
-----Original Message-----
From: "Raycoms" <[email protected]>
Sent: 2/14/2017 2:01 PM
To: "Minecolonies/minecolonies" <[email protected]>
Cc: "kreezxil" <[email protected]>; "Mention" <[email protected]>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike (#584)
bugs is something which does something we don't want without throwing
errors messages and are therefore quite hidden.
Errors can be easily be found because we always log them.
2017-02-14 17:59 GMT-02:00 kreezxil <[email protected]>:
Seems you know what I meant, is there a way to turn that on for your
"bugs"?
-----Original Message-----
From: "Marvin Hofmann" ***@***.***>
Sent: 2/14/2017 11:06 AM
To: "Minecolonies/minecolonies" ***@***.***>
Cc: "kreezxil" ***@***.***>; "Mention" ***@***.***
>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
(#584)
@kreezxil all actual errors get violently thrown at the console, the
problem are bugs not errors ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9y-lnWKmhcrQIY0Rmnba7XH8n-p41ks5rcgeagaJpZM4L-t7c>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
@kreezxil The thing is, such a debug log would cripple a server with output. We could do that but I'd say that is a github issue for itself ;)
I may have just given you $5, reason is, I did a world wipe on my test server and lo and behold the miner actually talks to me.
The only things that I can think that even cause this issue are:
- upgrading a minecolonies world with a new version of minecolonies
- using chunkloaders in your minecolony -- meaning that your people are talking to someone when you are not around and when you finally do show up perhaps they no longer want to talk to you (just theory and conjecture)
chunkLoaders 100% cause this.
They will talk to no one and then not talk for a while anymore
2017-02-15 21:05 GMT-02:00 kreezxil <[email protected]>:
… I may have just given you $5, reason is, I did a world wipe on my test
server and lo and behold the miner actually talks to me.
The only things that I can think that even cause this issue are:
1. upgrading a minecolonies world with a new version of minecolonies
2. using chunkloaders in your minecolony -- meaning that your people
are talking to someone when you are not around and when you finally do show
up perhaps they no longer want to talk to you (just theory and conjecture)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9y_imNMrsaqg-FnBE1V2d4YEcv9haks5rc4TTgaJpZM4L-t7c>
.
I think our timeout was 10 minutes right? Or was it more?
We incrementally increase the time it takes for a citizen to ask again but it has a cap
Thinking about this, seems it would be ideal that of no member of the colony was online the villagers would go quiet. However as soon as a member connects they should take talking. Why a chunk loader would cause the aberrant behavior doesn't make sense to me ... ?
…-----Original Message-----
From: "Marvin Hofmann" <[email protected]>
Sent: 2/16/2017 3:13 AM
To: "Minecolonies/minecolonies" <[email protected]>
Cc: "kreezxil" <[email protected]>; "Mention" <[email protected]>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike [$5](#584)
I think our timeout was 10 minutes right? Or was it more?
We incrementally increase the time it takes for a citizen to ask again but it has a cap
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
We usually assume that no chunkloaders are installed, therefore, if the
chunk is loaded, a player must be close.
2017-02-16 8:41 GMT-02:00 kreezxil <[email protected]>:
… Thinking about this, seems it would be ideal that of no member of the
colony was online the villagers would go quiet. However as soon as a member
connects they should take talking. Why a chunk loader would cause the
aberrant behavior doesn't make sense to me ... ?
-----Original Message-----
From: "Marvin Hofmann" ***@***.***>
Sent: 2/16/2017 3:13 AM
To: "Minecolonies/minecolonies" ***@***.***>
Cc: "kreezxil" ***@***.***>; "Mention" ***@***.***
>
Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
[$5](#584)
I think our timeout was 10 minutes right? Or was it more?
We incrementally increase the time it takes for a citizen to ask again but
it has a cap
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9y8fa-Z03eTpw_-6vMd-mFsswjLfyks5rdCfZgaJpZM4L-t7c>
.
We should probably check if there are players inside the colony before we process the messages
Well, there are chunk loaders that keep chunks loaded when players aren't
on a server, this behavior is allowed on quite a few servers, mainly the
smaller ones, and all of mine, as they are small in population only, chunk
loaders for ProsperCraft are limited to when a player is on, so it
shouldn't be so much an issue for them.
Making in assumptions in code might be ok for launching a manned colony
ship to Mars for the NASA team, but Minecraft? You probably need to not
assume because a chunk is loaded that the player is on, what if the player
had visitors walking about in their colony interacting with stuff but the
player and other colony members were all offline, the same scenario would
appear.
A custom event to check if any of the colony members are on should be
adequate to determine to what if at all the npcs should be talking too.
…On Thu, Feb 16, 2017 at 5:30 AM, Raycoms ***@***.***> wrote:
We usually assume that no chunkloaders are installed, therefore, if the
chunk is loaded, a player must be close.
2017-02-16 8:41 GMT-02:00 kreezxil ***@***.***>:
> Thinking about this, seems it would be ideal that of no member of the
> colony was online the villagers would go quiet. However as soon as a
member
> connects they should take talking. Why a chunk loader would cause the
> aberrant behavior doesn't make sense to me ... ?
>
> -----Original Message-----
> From: "Marvin Hofmann" ***@***.***>
> Sent: 2/16/2017 3:13 AM
> To: "Minecolonies/minecolonies" ***@***.***>
> Cc: "kreezxil" ***@***.***>; "Mention" <
***@***.***
> >
> Subject: Re: [Minecolonies/minecolonies] [2829] Miner still on strike
> [$5](#584)
>
> I think our timeout was 10 minutes right? Or was it more?
> We incrementally increase the time it takes for a citizen to ask again
but
> it has a cap
> —
> You are receiving this because you were mentioned.
>
> Reply to this email directly, view it on GitHub, or mute the thread.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#584 (comment)
280296245>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-
auth/AGI9y8fa-Z03eTpw_-6vMd-mFsswjLfyks5rdCfZgaJpZM4L-t7c>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADs0iCkjh4ngnOvKuMS9jFkYd0x7DzoIks5rdDNIgaJpZM4L-t7c>
.
@Raycoms we could check the subscriber list if there are any. Would still be a bit ugly to pass that to the spamfilter...
As per request I started merging Issues that are related to things I found while going through the source code. One of these is the request system. Closing this in favor of #638