Prerequisites

• I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
• I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
• I made sure that this issue is not a duplicate of any existing issue.

Context

• Minecraft Version: 1.16.3
• MineColonies Version: minecolonies-0.13.420-ALPHA-universal
• Structurize Version: structurize-0.13.96-ALPHA-universal
• Related Mods and their Versions:

Expected behavior

Guards would only request a shield when they don't have one.

Actual behavior

Guards constantly request and re-request shields.

Image shows a guard with a shield (verified in their inventory) and is requesting another one. I did not give them one at all, they already had one.

Steps to reproduce the issue

1. Verify they have a shield in their inventory, clear their request either through their interface or the clipboard
2. Wait 5-10 minutes
3. They request another shield.

Logs

• latest.log:
• crashlog:

Notes

Viewers

• Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
• Add a comment if you have any insights or background information that isn't already part of the conversation.

This still persists in minecolonies-0.13.547-ALPHA-universal and clearing / canceling / rearranging inventory etc doesn't help:

I want to add that guards also request shields even though the research hasn't been completed for it. Not sure if that should be in a separate issue.

Tried hiring/firing as well...FYI

FYI it happened with regular shields too. I just started a new playthrough so I will see if the issue persists in a new colony on a new world

Appreciated.

I only gave them the standard Minecraft shields - the colored ones must have been made by the guards themself?

@Raycoms, could this have something to do with NBT? it looks like the shield in both pictures has been crafted with a banner.

Yes, the guards color them themselves

Okay. I'll start digging into this.

I tried to reproduce this but couldn't. Is there any nbt data on it?

Nvm, I got 2 nbt tags on the shield here but it still works fine.

Update: I just hired 2 Knights in my newly created colony on a brand new world (0.13.566-ALPHA) and having the exact same issue.

The shield in the Knight's inventory has no special NBT tags

is this before researching or after researching shields?

Does this happen with the newest alpha too? I've changed some things around NBT recognition

is this before researching or after researching shields?

Before researching shields. It is a brand new colony.

Does this happen with the newest alpha too? I've changed some things around NBT recognition

I will test with the new version tonight when the server is empty

Upgrading and then resetting the colony request system did it. Thanks, Raycoms!

Sadly the issue is back. My guards died and I hired from the tavern. Both have shields, both are requesting them. I reset the request system and they go back to requesting shields

Update: Some of my guards stopped asking for shields so I thought it had fixed itself. Nope! They are hoarding! LOL

I noticed this yesterday too, so this morning I updated to .596 and took all the extra shields away from my guards, and now have one asking for another (they have 1 undamaged one on them) Only been playing 10 minutes, so I assume the others will ask soon too

I want to add that guards also request shields even though the research hasn't been completed for it. Not sure if that should be in a separate issue.

different issue prolly

Fixed

same as #5395