MineColonies

MineColonies

53M Downloads

Damage research does not increase damage after 1st tier (until 6th tier)

norbby42 opened this issue ยท 0 comments

commented

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.15.2
  • MineColonies Version: 0.13.441-ALPHA
  • Structurize Version: 0.13.94-ALPHA
  • Related Mods and their Versions:

Expected behavior

Each additional research to increase either melee or ranged damage would incrementally increase the damage done.

Actual behavior

Once the first +damage upgrade is researched, subsequent upgrades (excluding the tier 6) do not increase the damage done.

Steps to reproduce the issue

  1. Build a guard tower and equip a guard with a wooden sword
  2. Research in the Combat tab: Accuracy (pre-requisite) and Quick Draw
  3. Observe how much damage the guard does to a non-armored mob (like a Spider) ; You'll probably need a 3rd party addon like The One Probe to see the mob's HP
  4. Research in the combat tab: Power Attack and Cleave ; this should increase the damage done by a half a heart.
  5. Observe how much damage the guard does to a non-armored mob (ie Spider).
  6. Note that the damage is the same as in step 2.

Logs

  • latest.log:
  • crashlog:

Notes

This appears to be happening because the research definitions set all of the MELEE_DAMAGE and ARCHER_DAMAGE AdditionModifierResearchEffect to the same value (except T6), so when the higher tier research is completed and it attempts to override the existing modifier, it finds the modifier of 0.5 already present and makes no changes.

The research UI is pretty confusing about this, because to an average observer it looks like each tier would be increasing the damage done by +0.5 (as is written in the UI). Same with the percent increases for the other researches - Nowhere does it say that research is not cumulative, but "highest value wins".

PS - Research names "Tick Shot" should probably be "Trick Shot", and "Repost" should probably be "Riposte".


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.