MineColonies

MineColonies

53M Downloads

Vanilla magic mod can bypass minecolonies protections.

ProsperCraft opened this issue · 12 comments

commented

Minecolonies version

minecolonies-universal-1.11-0.6.2837

Steps to reproduce the problem

  1. Install Vanilla magic
  2. Work through all of the achievements
  3. Shift right click with a blaze rod with a book in your offhand while having the proper achievements

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

commented

I did add the Event that is fired when Player will try to save / load block. Canceling this event should prevent block from being taken.
Event class

commented

@Sejoslaw you should probably fire break and place events when you swap the blocks. Blindly just changing blocks can cause a lot of problems!

commented

Maybe even trigger the respective methods on the blocks that you manipulate.

commented

If You could write the list of blocks that should be blacklisted I could add some kind of blacklist to this spell.

commented

It seems that Vanilla Magic does not respect/trigger events with what it does.

Many mods do this for efficiency (and well, it's easier that way) but we can't protect against mods that do not trigger events.

@Sejoslaw A blacklist won't work. You would have to issue events for all changed blocks (and other world interactions) and respect that other mods can cancel these events. Without that no protection system can protect against changes.

commented

@Sejoslaw @ProsperCraft any news on this?

commented

@Kostronor Is Minecolonies about to be updated to 1.11.2 ?

commented

@Kostronor I did try to run the newest version of Minecolonies and it crashed - Crash Report

commented

@Sejoslaw that looks bad 😅
Can you open a separate issue for that? Looks like a build problem

commented

Sure :)

commented
commented

Closing, waiting on dev of vanilla magic