Deliverman voiding fish when one half of a chest in the warehouse if full
ProsperCraft opened this issue · 9 comments
Minecolonies version
minecolonies-universal-1.11-0.6.2837
Expected behavior
Deliveryman use entire chest, not half of a chest, and then use other empty chests when the main chest is full.
Actual behaviour
http://imgur.com/mHawQSw
Deliveryman using half of the chest, and then voiding the extra fish.
I started working on the Deliveryman System now. I have added a note to its usecase study.
All relevant information can be found in issue: #638, Closing in favor for that issue and as this is not really a bug. Please continue discussing it in the mentioned Issue.
Problem is that the items do disappear and don't go into other chests.
Something seems wrong with the "isChestFull" check most probably.
I run into this too, but with the logs. Even though there are a lot of empty chests in my warehouse, the only one that has Oak/Spruce/Jungle/Birch wood is on the lower half of a double chest which is completely full (the upper half still has room). Perhaps it is looking for space in the wrong "single chest" of the double chest.
I was about to ask why you were checking for "this" instead of "entity" in https://github.com/Minecolonies/minecolonies/blob/72186127d3458e4c020a1995b964e258e1a7559b/src/main/java/com/minecolonies/coremod/tileentities/TileEntityWareHouse.java#L411 but seems like you saw it already.