MineColonies

MineColonies

57M Downloads

White items (Beds, Quartz blocks) showing up Gray in Clipboard

ShaneCourtrille opened this issue ยท 15 comments

commented

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.16.5
  • MineColonies Version: minecolonies-0.13.620-ALPHA-universal
  • Structurize Version: structurize-0.13.134-ALPHA-universal
  • Related Mods and their Versions:

Expected behavior

White items should show up correctly in the clipboard

Actual behavior

Items such as White Beds/Chiseled Quartz Block are appearing with a grayish color as shown below. Interestingly enough the banner in the same screenshot does not have this color issue.

2021-02-16_21 16 20

Steps to reproduce the issue

Not sure if this will reproduce for anyone else and I don't have another game far enough in to test against.

Logs

  • latest.log:
  • crashlog:

Notes


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

Also happening in the Builder Required Resources list and for non-white things like Cobblestone.

commented

I know about this and the fix is kinda super hard, it's problem with lighting the block during rendering it into the icon, low priority fix

commented

Was this always a problem, or only recently?

commented

I know the cause (recent thing) but vanilla lacks rendering item icons using matrixstack, so nope from me until they fix it or I will learn how to persuade lighting to shift with the matrixstack

commented

Could we theoretically render item entities?

commented

? 3d rendering in 2d? :D and the lighting issue probably won't go that easily

commented

Nah, render them in 3d =D

commented

Yep, ok, go set this up, enjoy having pain for like week before you manage to get code so good it handles all the possible rotations based on itemstack

commented

xD

commented

Can you "borrow" the method that JEI or TOP use? They don't seem to have the issue.

commented

One thing to mention is that I recently upgraded from an earlier version (603 maybe?) and this problem didn't exist in that version. Would it be helpful if I did a version bisect to see at what version it starts appearing?

commented

Not to worry, we know what the problem is

commented

There is a method in the Render utils that mc provides

Both to enable and disable it
See new bo for examples by also mc itself EG slots

commented

It's not enough, the lighting source is simply shifted, you can't fix that by vanilla things only, partial fix incoming
edit: and new bo is still not matrixstack based

commented