MineColonies

MineColonies

53M Downloads

[Minor] Names does not contain spaces if middle initials are off

hron84 opened this issue · 2 comments

commented

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.16.5
  • MineColonies Version: 0.14.138
  • Structurize Version: 0.13.169
  • Related Mods and their Versions:

Expected behavior

I'm trying to spawn in citizens with Hungarian names. In Hungary, using middle initials is not common, so I decided to disable this setting. However, if I turn off using middle initials and turn on eastern name generation, there is no space between the last name and the first name (e.g the name generated is NemesKata and not Nemes Kata).

Actual behavior

Steps to reproduce the issue

Config:

[names]
    #Male first names to be used for colonists 
    malefirstnames = ["Ádám", "Dániel", "Tamás", "Bence", "Péter", "Dávid", "Márk", "László", "Zoltán", "Krisztián", "Máté", "Gábor", "Attila", "Richárd", "Balázs", "István", "Zsolt", "Norbert", "Gergő", "Roland", "János", "József", "Sándor", "Martin", "Bálint", "András", "Patrik", "Csaba", "Róbert", "Kristóf", "Tibor", "Ákos", "Szabolcs", "Ferenc", "Viktor", "Gergely", "Márton", "Levente", "Marcell", "Alex", "Erik", "Imre", "Mihály", "Miklós", "György", "Benjámin", "Mátyás", "Áron", "Milán", "Lajos", "Barnabás", "Gyula", "Dominik", "Károly", "Olivér", "Béla", "Szilárd", "Zsombor", "Adrián", "Pál", "Nándor", "Árpád", "Márió", "Renátó", "Szilveszter", "Kornél", "Benjámin", "Benedek", "Antal", "Arnold", "Dénes", "Botond", "Géza", "Valentin", "Kálmán", "Ábel", "Rajmund", "Soma", "Krisztofer", "Bertalan", "Kevin", "Vilmos", "Barna", "Henrik", "Endre"]
    #Female first names to be used for colonists 
    femalefirstnames = ["Alexandra", "Vivien", "Viktória", "Dóra", "Nikolett", "Fanni", "Eszter", "Barbara", "Anna", "Klaudia", "Zsófia", "Krisztina", "Réka", "Kitti", "Petra", "Renáta", "Bettina", "Evelin", "Adrienn", "Enikő", "Brigitta", "Cintia", "Bianka", "Anita", "Andrea", "Laura", "Noémi", "Boglárka", "Bernadett", "Katalin", "Fruzsina", "Nikoletta", "Nóra", "Dorina", "Rebeka", "Regina", "Anett", "Dorottya", "Szilvia", "Lilla", "Mónika", "Tímea", "Zsanett", "Ágnes", "Kinga", "Zsuzsanna", "Éva", "Szabina", "Dalma", "Gabriella", "Diána", "Orsolya", "Mária", "Beatrix", "Edina", "Dominika", "Henrietta", "Gréta", "Judit", "Erika", "Csilla", "Virág", "Emese", "Melinda", "Ramóna", "Anikó", "Luca", "Ildikó", "Veronika", "Mercédesz", "Erzsébet", "Annamária", "Ivett", "Sára", "Tünde", "Georgina", "Rita", "Flóra", "Dzsenifer", "Lili", "Szimonetta", "Beáta", "Hajnalka", "Tamara", "Kata"]
    #Should new citizens use the Eastern name order (with their surname first)? [Default: false]
    useeasternnameorder = true
    #Should citizens have a middle initial? [Default: true]
    usemiddleinitial = false
    #Last names to be used for colonists 
    lastnames = ["Nagy", "Lukács", "Jónás", "Kovács", "Gulyás", "Szücs", "Tóth", "Biró", "Hajdu", "Szabó", "Király", "Halász", "Horváth", "Balog", "Máté", "Varga", "László", "Székely", "Kiss", "Bogdán", "Gáspár", "Molnár", "Jakab", "Kozma", "Németh", "Katona", "Pásztor", "Farkas", "Sándor", "Bakos", "Balogh", "Váradi", "Dudás", "Papp", "Boros", "Virág", "Lakatos", "Fazekas", "Major", "Takács", "Kelemen", "Orbán", "Juhász", "Antal", "Hegedüs", "Oláh", "Orosz", "Barna", "Mészáros", "Somogyi", "Novák", "Simon", "Fülöp", "Soós", "Rácz", "Veres", "Tamás", "Fekete", "Budai", "Nemes", "Szilágyi", "Vincze", "Pataki", "Török", "Hegedűs", "Balla", "Fehér", "Deák", "Faragó", "Balázs", "Pap", "Kerekes", "Gál", "Bálint", "Barta", "Kis", "Illés", "Péter", "Szűcs", "Pál", "Borbély", "Orsós", "Vass", "Csonka", "Kocsis", "Szőke", "Mezei", "Fodor", "Fábián", "Sárközi", "Pintér", "Vörös", "Berki", "Szalai", "Lengyel", "Márton", "Sipos", "Bognár", "Magyar", "Bodnár"]

Start the world with this server config, and wait 'til a ciitzen / visitor spawn in with new name generation rules.


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

I pinpointed the problem. Here you should do this:

            citizenName = String.format("%s %s", lastName, firstName);
commented

If you've fixed it, you're welcome to make a pull request!