MineColonies

MineColonies

53M Downloads

Composter not obeying minimum amount to be left in warehouse.

dupontct opened this issue ยท 0 comments

commented

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.16.5
  • MineColonies Version: 0.14.215-ALPHA
  • Structurize Version: 0.13.177-ALPHA
  • Related Mods and their Versions:

Expected behavior

When the Composter is set to leave 16 items in the warehouse. It requests enough items to leave only 16 items in the warehouse.

Actual behavior

Composter will only request enough items to leave 64 of an item in the warehouse regardless of the value in the Min Warehouse Stock setting.

Steps to reproduce the issue

  1. Build initial Townhall plus Warehouse, Composter, and Courier and hire workers for each.
  2. Note that the Min Warehouse Stock setting in the composter's hut is set to 16.
  3. Allowed dried kelp to be composted.
  4. Place 64 dried kelp in warehouse.
  5. Note that Composter still requires dried kelp but nothing is delivered even though there is more then 16 dried kelp in the warehouse.
  6. Add 32 dried kelp to warehouse.
  7. Note that 32 dried kelp is delivered and 64 dried kelp is left in the warehouse.

Notes

Problem is that the code:

worker.getCitizenData().createRequestAsync(new StackList(itemList, COM_MINECOLONIES_REQUESTS_COMPOSTABLE, Constants.STACKSIZE * getOwnBuilding().getBarrels().size(), 1, 64));

should probably be:

worker.getCitizenData().createRequestAsync(new StackList(itemList, COM_MINECOLONIES_REQUESTS_COMPOSTABLE, Constants.STACKSIZE * getOwnBuilding().getBarrels().size(), 1, getOwnBuilding().getSetting(BuildingComposter.MIN).getValue()));

Can't figure out how to get the a useable .jar file that minecraft will run, so I can verify the fix; or I would submit a PR. The jar file created by the gradle build task and the minecraft instance launched by the gradle runClient task both have the mod loader error out saying that the mod jar file constructed 0 mods: [], but had 1 mods specified: [minecolonies]


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.