Scanning a Large Area Disconnects the Player
WenXin20 opened this issue · 13 comments
Minecolonies version
version 0.6.3125-1.10.2
Expected Behavior
- To be able to scan a large area
Actual Behavior
- After scanning a large area, I was sent to a 'disconnected from world' screen from my singleplayer world.
Steps to reproduce the problem
- Scan a large area
- Confirm the scan and then get disconnected from the world.
@Raycoms Are you referring to my branch ?
I haven't touch the scanning part. Also as it is in single player, I am not sure what is causing this.
I don't think the issue should have been closed.
Their is virtually no limit to the packet size in SSP
The packet size limit in SMP comes from the packet type Minecraft configures Netty with.
It is something around 32 kB if i am not mistaken. However for SSP that packet type is not used, and no limit is actually implemented
Yeah but we send messages in ssp. We could detect if we are in a ssp game
and then simple directly store it but the forge guys said there is no
reliable way for this
2017-03-24 12:58 GMT-03:00 Orion <[email protected]>:
… Their is virtually no limit to the packet size in SSP
The packet size limit in SMP comes from the packet type Minecraft
configures Netty with.
It is something around 32 kB if i am not mistaken. However for SSP that
packet type is not used, and no limit is actually implemented
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#723 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9y_o5n9hqDuasjnaRqfRzq_mNW-Gwks5ro-g3gaJpZM4MjYVe>
.
because of lan games etc
2017-03-24 14:48 GMT-03:00 Ray Neiheiser <[email protected]>:
… Yeah but we send messages in ssp. We could detect if we are in a ssp game
and then simple directly store it but the forge guys said there is no
reliable way for this
2017-03-24 12:58 GMT-03:00 Orion ***@***.***>:
> Their is virtually no limit to the packet size in SSP
> The packet size limit in SMP comes from the packet type Minecraft
> configures Netty with.
> It is something around 32 kB if i am not mistaken. However for SSP that
> packet type is not used, and no limit is actually implemented
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#723 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AGI9y_o5n9hqDuasjnaRqfRzq_mNW-Gwks5ro-g3gaJpZM4MjYVe>
> .
>
I thought you worked on the transfer between to the client as well?
2017-03-24 6:02 GMT-03:00 xavierh <[email protected]>:
… @Raycoms <https://github.com/Raycoms> Are you referring to my branch ?
I haven't touch the scanning part. Also as it is in single player, I am
not sure what is causing this.
I don't think the issue should have been closed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#723 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9y1Hx5iVIiFXf9gTjuHGwJx5kIEIqks5ro4aagaJpZM4MjYVe>
.
Could you then use the compression and way you transfer it to the server as well to transfer it from server to client side on the single player?
This is where the crash happens atm.
Only working on transferring schematics from client to server and server to client, not on the scan part. However I can add the same compression to it.
I will reopen the issue and assign it to me as a reminder.
However in the present case, the error occurred in SP which AFAIK does not use any network transfer. Not too sure why it is crashing here.
@WenXin20 could you submit the log file ?
It is crashing because it still has to transfer things from server to client side even in singlePlayer. (The creation of the nbt happens on the server and we have to send it to the client)
I thought we had a isDedicatedServer method or something like that.
Regardless of that we can avoid the crash at least.
…On 24 Mar 2017 17:48, "Raycoms" ***@***.***> wrote:
Yeah but we send messages in ssp. We could detect if we are in a ssp game
and then simple directly store it but the forge guys said there is no
reliable way for this
2017-03-24 12:58 GMT-03:00 Orion ***@***.***>:
> Their is virtually no limit to the packet size in SSP
> The packet size limit in SMP comes from the packet type Minecraft
> configures Netty with.
> It is something around 32 kB if i am not mistaken. However for SSP that
> packet type is not used, and no limit is actually implemented
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#723 (comment)
289064227>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AGI9y_
o5n9hqDuasjnaRqfRzq_mNW-Gwks5ro-g3gaJpZM4MjYVe>
> .
>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#723 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACplvJry2rIx1pnAEVQMjD3khaxOTw6Wks5rpAH-gaJpZM4MjYVe>
.
The problem is that in the case of lan games that doesn't work very well ,
regarding forge.
2017-03-24 15:39 GMT-03:00 xavierh <[email protected]>:
… I thought we had a isDedicatedServer method or something like that.
Regardless of that we can avoid the crash at least.
On 24 Mar 2017 17:48, "Raycoms" ***@***.***> wrote:
> Yeah but we send messages in ssp. We could detect if we are in a ssp game
> and then simple directly store it but the forge guys said there is no
> reliable way for this
>
> 2017-03-24 12:58 GMT-03:00 Orion ***@***.***>:
>
> > Their is virtually no limit to the packet size in SSP
> > The packet size limit in SMP comes from the packet type Minecraft
> > configures Netty with.
> > It is something around 32 kB if i am not mistaken. However for SSP that
> > packet type is not used, and no limit is actually implemented
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <#723 (comment)
> 289064227>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/AGI9y_
> o5n9hqDuasjnaRqfRzq_mNW-Gwks5ro-g3gaJpZM4MjYVe>
> > .
> >
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub
> <#723 (comment)
289095649>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
ACplvJry2rIx1pnAEVQMjD3khaxOTw6Wks5rpAH-gaJpZM4MjYVe>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#723 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGI9y_Q3vXDgitGUY9bqn9EvGB3XEVqRks5rpA3zgaJpZM4MjYVe>
.
