Can't fire or hire citizens from library
MotionlessTrain opened this issue ยท 4 comments
Prerequisites
- I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
- I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
- I made sure that this issue is not a duplicate of any existing issue.
Context
- Minecraft Version: 1.16.5
- MineColonies Version: 1.0.191-alpha
- Structurize Version: 0.13.252-alpha
- Related Mods and their Versions: none
Expected behavior
I can hire a cook directly from a library in the "manage worker" window
Actual behavior
After hiring, it shows it hired a "Student: " instead of "Cook: ".
After closing the world and reopening, the citizen turned out not to be hired as well.
I tried to manually fire the same student from the library, and hire them while they were unemployed, but that didn't work either.
Looking in the log, both threw a NPE in the HireFireMessage.
Steps to reproduce the issue
- Hire someone at the library (if possible)
- Try to hire them somewhere else
- Try to fire them instead.
Logs
After multiple relogs, trying to reproduce the issue, I managed to get the two crashes relatively close together.
(Just separated by a lot of Journeymap errors...)
At the very bottom of the log.
The error seems to be exactly the same, except for the line number in the line it throws (90 vs 94).
Notes
The firing seems to be a problem at multiple buildings. I wasn't able to fire my sifter either.
Viewers
- Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
- Add a comment if you have any insights or background information that isn't already part of the conversation.
This is also not working on 1.17 with version 1.0.192-alpha, judging from discord
latest.log including the issue on 1.17 / 1.0.192:
https://gist.github.com/TheMerced/9a6d464f24c024a40cf0299e68ed963e
Could it be not all assignment modules in the worker buildings are instanceof IAssignsJob? Cause that seems what the error is indicating.
According to commit 059cd10 where the IAssignsJob interface was introduced, only the courier assignment module is implementing it.
