MineColonies

MineColonies

Mods
57M Downloads

Single tag on an dictionaried item causes the recipe to show up for the wrong professions in JEI, even if a valid substitute exists

BrainInBlack opened this issue ยท 0 comments

commented

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.16.5
  • MineColonies Version: 1.0.365-ALPHA
  • Structurize Version: 1.0.339-ALPHA
  • Related Mods and their Versions: The Undergarden 0.5.5

Expected behavior

For recipes to show up for the right profession, regardless if there is a blacklisted item in the recipe that could be substituted.

Actual behavior

In my case Undergarden's Twistytwig is dictionaried via #forge:rods/wooden with vanilla sticks, but is carrying #minecolonies:sawmill_ingredient_excluded as well. Making recipes using #forge:rods/wooden to not show up for the carpenter in JEI. Instead, they show up for the fletcher, because of #minecolonies:fletcher_ingredient, #minecolonies:fletcher_product, and (probably) #forge:string is attached to the Twistytwig.

2022-01-28_22 23 22
2022-01-28_22 27 31

Steps to reproduce the issue

  1. Install Undergarden
  2. Look up the usage of any item that is using sticks, that should show up for the carpenter
  3. It won't show up

(Kind of silly for this kind of issue)

Logs

N/A

Notes

As the title suggests, a substitutable item should not make a recipe invalid for the intended profession. Unless there are no further substitutes for an item, it should always show up for the intended profession, especially for vanilla recipes.

In the case that the player is trying to use an invalid/blacklisted item for a recipe, a simple indicator in the UI could help reports to pile up here or on the discord. Unless there is a way to only show the valid ingredients for that specific recipe and profession.

Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.