MineColonies

MineColonies

Mods
53M Downloads

No empty bowl left after citizens eat the soup

Tidy-Bear opened this issue ยท 0 comments

commented

Prerequisites

  • I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
  • I made sure that this issue is not a duplicate of any existing issue.

Context

  • Minecraft Version: 1.16.5
  • MineColonies Version: 1.0.432-ALPHA
  • Structurize Version: Irrelevant
  • Related Mods and their Versions: None

Expected behavior

The empty bowl will be returned after citizens eat the soup, such as mushroom stew, beetroot soup, and soup from other mods.

Actual behavior

By default, SoupItem has no CraftingReaminItem. So containerItem in the

minecolonies/src/main/java/com/minecolonies/coremod/entity/ai/minimal/EntityAIEatTask.java

Line 287 in 651f170

final Item containerItem = stack.getItem().getCraftingRemainingItem();
will be null and nothing will be left.

Steps to reproduce the issue

  1. Wait for a citizen to be hungry
  2. Give him a mushroom stew, or other soup
  3. They eat soup and bowl

Logs

  • latest.log:
  • crashlog:

Notes

Players can get empty bowl because SoupItem override finishUsingItem(). Sadly, only PlayerEntity can :(

Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.