MineColonies

MineColonies

Mods
57M Downloads

[BUG] Fisherman endlessly cycles without fishing

uecasm opened this issue ยท 0 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Verison?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

Minecraft Version

1.16

MineColonies Version

1.0.540-ALPHA

Structurize Version

1.0.371-ALPHA

Related Mods and their Versions

Forge 36.2.29

Current Behavior

The fisherman walks to their hut block, walks to the center of a pool, walks back to their hut block, repeating forever. They don't actually do any fishing.

Expected Behavior

They actually do some fishing.

Reproduction Steps

Give the fisherman precisely a 7x7 pool of water, with no other pools nearby, and surrounded on all but one side with fences.

The AI happens to pick a water block in the center of one of the fence sides as the "pond" location. (The "standing location" that it picked also is a water block; not sure if that's random or if it just picked something that wasn't the fence.)

minecolonies/src/main/java/com/minecolonies/coremod/entity/ai/citizen/fisherman/EntityAIWorkFisherman.java

Lines 313 to 316 in 8fca9b1

if (world.getBlockState(worker.blockPosition()).getMaterial().isLiquid())
{
return START_WORKING;
}

At this point, it detects that the chosen block is water, then it resets to retry the whole state machine again -- except that it hasn't changed the pond or any other conditions, so it will just go right back here again indefinitely.

Possibly the "real bug" is that the pond search reported two water blocks and not a good standing location, but this reset doesn't seem to be resetting properly. Or perhaps I'm missing something, but it's not right as is.

Logs

n/a

Anything else?

Might be nice to have it look for a "work" tag as a preferred place to stand while fishing (though perhaps still searching for others).

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.