MineColonies

MineColonies

53M Downloads

Nether Miner not working

SerranoPancake opened this issue · 25 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Verison?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

Minecraft Version

1.18

MineColonies Version

1.0.553-ALPHA

Structurize Version

1.0.369-ALPHA

Related Mods and their Versions

  1. Forge 39.1.2
  2. Domum 1.0.49-ALPHA
  3. blockui 0.0.47

Current Behavior

Nether miner complaining that they cannot work
image

Expected Behavior

Once supplied with needs, they should enter Nether and do their job

Reproduction Steps

  1. Hire Nether miner
  2. Fulfill all requests for all tools, food and other.
  3. Nether miner walks around their hut with speech bubble icon and says they haven't been able to work

Logs

https://gist.github.com/SerranoPancake/8e5b8fde44b79e087262dc73265fc191

Anything else?

I've tried to fire/rehire. I've run the reload command on the citizen. I've fired, emptied inventory and rehired. Nether miner hut is wooden level 4

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

The worker does walk around the area also, they just happened to be jumping up and down beside their rack at that particular time.

commented

As additional info (not sure if this is related to the issue or not): The portal tag exists on the wooden nether mine, the vault tag does not.
According to the discord conversation, they don't actually go into the nether, but just "stand besides their racks and jump up and down"

commented

Just upgraded Nether miner to level 5. Still doing the same thing.

commented

What does the nether miner (the citizen) have in their inventory?

commented

Here is the workers inventory:
image

Here is the rack in the hut:
image

The hut block itself doesn't have anything.

commented

Ok, that looks like you don't have all the supplies for the trip. I'd suggest clearing the ladders and torches out, and letting them re-request.

commented

Also for reference, here is a screenshot of the tags:
image

commented

It's the lack of the vault tag. PR with fix was already made

commented

If you look in the hut recipes, it will show you what is necessary for it to go. I believe it's ladders, torches, and cobblestone.

commented

Ok, that looks like you don't have all the supplies for the trip. I'd suggest clearing the ladders and torches out, and letting them re-request.

I have cleared everything out of their inventory and had them request it all again. It didn't help. Tell me what they are missing...

commented

It's the lack of the vault tag. PR with fix was already made

What is "PR" and where do I get it?

commented

its fixed in dev. just needs to be added to the mod

commented

its fixed in dev. just needs to be added to the mod

Already added

commented

The wooden nether miner has got a vault (and its roof and framed blocks) in 1.0.562

commented

The vault is not required for the netherminer to function, as far as I can tell from the code. There is something else going on here, I think.

commented

@SerranoPancake Could you try again on 1.0.562?

commented

Before updating to 1.0.562 I gave the netherminer a stack of ladders and they went right to work. Even after emptying their inventory and having them request required resources again, they still did not have enough ladders. I triple checked the requests and never saw a request for more ladders. Not sure what the "vault" tag does so I can't speculate on whether it had anything to do with the issue, but the netherminer has been working ever since

commented

Ah, so it seems that they don't properly request ladders?
The vault tag is something which is needed/good to have for when the nether miner is in the nether

commented

@MotionlessTrain I suspect it's requesting ladders just fine now. I've seen cases when I was writing the netherminer where it would get a partial delivery, and never ask for more, but once you manually filled the gap, it would recover and work just fine for quite a while.

As for the vault tag, as now proven the netherminer works just fine without it, as was the design. It was added to be able to move the invisible netherminer somewhere that other mods couldn't reveal it and that was 'safe'. Without the vault tag, the miner just stands inside the portal invisible, but not invulnerable.

commented

@MotionlessTrain I suspect it's requesting ladders just fine now. I've seen cases when I was writing the netherminer where it would get a partial delivery, and never ask for more, but once you manually filled the gap, it would recover and work just fine for quite a while.

Interesting that they can get stuck on a partial request like that.

As for the vault tag, as now proven the netherminer works just fine without it, as was the design. It was added to be able to move the invisible netherminer somewhere that other mods couldn't reveal it and that was 'safe'. Without the vault tag, the miner just stands inside the portal invisible, but not invulnerable.

You seemed to be right indeed. I'm glad that it is now clear that that wasn't the issue.

commented

So, having ladders, but not enough is the issue?

commented

Yes, even though they didn't have enough, they were not requesting anymore. Once I supplied them with the needed amount, they continued working.

commented
commented

No vault tag, no working. That's the problem Sent from ProtonMail mobile

-------- Original Message --------
On Mar 28, 2022, 22:58, SerranoPancake wrote: The worker does walk around the area also, they just happened to be jumping up and down beside their rack at that particular time. — Reply to this email directly, [view it on GitHub](#8195 (comment)), or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

I thought the vault tag wasnt entirely needed

commented

No, as explained by Mekle above. I have the feeling something went wrong at Github, and this message was pending for quite a while. I have seen several email responses at (closed) old issues at roughly the same time.