MineColonies

MineColonies

53M Downloads

[BUG] Y axis of paintings increasing every time a schematic rotate

emanuele246gi opened this issue · 13 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Verison?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

Minecraft Version

1.16

MineColonies Version

1.0.554

Structurize Version

1.0.371

Related Mods and their Versions

Forge: 36.2.33

Current Behavior

2022-03-31_12 35 19

Expected Behavior

Paintings staying in the original y position

Reproduction Steps

To see it in the preview, rotate a schematic with paintings in it and look for them, every time you rotate they will go up

Logs

Too large

Anything else?

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

This was fixed for 1.18, not sure if there is way/will to backport it
Issue tracking progress for 1.18 ldtteam/Structurize#426

commented

Well I just made the issue here on Github as they said it to me on Discord

commented

I thought Sam fixed this a year ago

commented

I checked and this is not a problem anymore. Althouigh painting placement isn't really perfect.

commented

2022-10-04_15 53 54

Of course it's still a problem. The painting wasn't supposed to be attached to the roof, but a block below this position

commented

Now I'm in the 1.18.2 version, with minecolonies-1.18.2-1.0.1048-BETA and with structurize-1.18.2-1.0.424-ALPHA

commented

2022-10-04_15 59 10
Look at this, how is the issue not there anymore?

commented

Could it be that the issue was only fixed in 1.19? (in which case, 1.18 will probably get the fixes later)

commented

In that case I can wait, thanks for the answer!

commented

okay, so the issue name is misleading. Actually, it offsets paintings by 1, but randomly. In 1.19 it is at most by 1, not with each rotation but rather based on the weird way images are processed

commented

I haven't looked at things recently, but in the past one issue was that it used the coordinate of the corner instead of the coordinate of the center (or vice versa), so it worked for 1x1 paintings but not for larger ones.

commented
commented

Thank you guys, I really love your mod!