Research tree requirements lists "totaling levels" for buildings that can only be built once
Thodor12 opened this issue ยท 5 comments
Is there an existing issue for this?
- I have searched the existing issues
Are you using the latest MineColonies Version?
- I am running the latest alpha version of MineColonies for my Minecraft version.
I am also running the latest (possible) versions of other mods that are part of my problem.
Did you check on the Wiki? or ask on Discord?
- I checked the MineColonies/Structurize Wiki or I asked on discord. Or I was sent from discord to open an issue here.
Minecraft Version
1.18
MineColonies Version
1.0.765-ALPHA.jar
Structurize Version
1.0.399-RELEASE.jar
Related Mods and their Versions
No response
Current Behavior
When you hover over a research it shows the building requirements, for buildings like a town hall (which can only be built once) the below message is unnecessary since the building can only be built once.
Expected Behavior
The research tree should respect limits to certain buildings and change the requirement messages accordingly.
At the time of writing this only applies to:
- Town hall
- Tavern
Reproduction Steps
- Build a university
- Open any research tree
- Look for a research which has a town hall or tavern as requirement (ex. "Combat > Boiled Leather")
Logs
N/A
Anything else?
No response
Footer
Viewers
- Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
- Add a comment if you have any insights or background information that isn't already part of the conversation.
At the research-tree level, it is actually checking for what it claims, so the tooltip is correct.
When someone defines a research, they can choose to set a different limit property if they want to limit on "a single building being at least level N" instead of that. Currently this is only used for the sifter unlocks, not the "classic" research.
So this isn't really a bug. You could perhaps argue that the single-allowed buildings ought to use that other property instead, but that might be more fragile if in the future it was decided to allow multiple taverns, for example.
Instead of defining the building limit requirement on a per research basis, woudn't it be more beneficial to have a proper limiter defined in the AbstractBuilding itself, that way the research can make use of that (if not explicitly defined in the research itself).
It would at least be used on the townhalls to always force 1 of them (and for now taverns aswell).
That could then also be used to improve the build tool logic so there's no special cases in constructing certain buildings like the way this is currently handled, it would just become a generic way.
The way it is now is more flexible. There may be research in the future that requires a level 3 house, not house(s) totalling 3 levels. If this would be defined in the AbstractBuilding, that flexibility is gone.
The way it is now is more flexible. There may be research in the future that requires a level 3 house, not house(s) totalling 3 levels. If this would be defined in the AbstractBuilding, that flexibility is gone.
I did state (if not explicitly defined in the research itself). I'm not saying remove the option, but make it also take into consideration the overall building limit.
