MineColonies

MineColonies

59M Downloads

[BUG] Raids don't respect the minimumnumberofnightsbetweenraids option

MotionlessTrain opened this issue ยท 10 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Verison?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.19.2

MineColonies Version

1.1.230

Structurize Version

1.0.652

Related Mods and their Versions

Forge 43.2.0
BlockUI 0.0.92
DO 1.0.137

Current Behavior

Two days after a raid starts, the next raid starts.
In one case for me, it almost looked like a raid got aborted, so that the next raid could start 2 minutes later (and the citizens had three days free of work)
I another case, after a few pirates slaughtered 5 of my guards, I had basically one day to clean up the graves, loot the pirate ship, hire visitors to fill back the empty guard spots, and give them the materials needed to actually be able to work

Expected Behavior

After a raid ends, the next raid starts in on average averagenumberofnightsbetweenraids days, and at least minimumnumberofnightsbetweenraids days.

Reproduction Steps

  1. Have a colony which is developed enough to get raided automatically
  2. Let raids spawn naturally
  3. After getting rid of the raid, wait a couple of days for the next raid

Logs

https://gist.github.com/MotionlessTrain/0c15aed77a6fc9e3f20356a8dd91a0a2

Anything else?

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

I've had to completely turn off raids for now (in serverconfig/minecolonies-server.toml) because of this issue:

dobarbariansspawn = false

commented

If you mean that it got fixed by 9474d7d, then I'm not sure how that would work
From a discord report, it seems that 1.1.232 still has the issue (though I haven't had the time yet to verify that)

commented

fixed

commented

That bug stopped the "night processing" for a lot of colonies, which can cause repetitive raids

commented

I still have the same issue on 1.1.232 as well

commented

post the new latest.log then

commented

I tried to restart the game as well, just in hope that would help (^ that log is from before the restart), but that doesn't seem to help

commented

was helpful to confirm that the other bug is fixed^^

commented

I actually didn't know about that other bug.
I did read the first log a little bit, but apparently not enough to see that that error ๐Ÿ˜„
Glad to help with that as well!