Minecraft Comes Alive (MCA)

Minecraft Comes Alive (MCA)

13M Downloads

Crashing on attacking entities with villager override off.

Its-Patchi opened this issue ยท 2 comments

commented
  • I am running the latest mod versions of MCA and RadixCore.
  • I can reproduce this issue with just MCA and RadixCore installed.
  • I can provide my Minecraft version and MCA version.
  • I have searched for the issue previously and it was either not previously reported, or previously fixed and I'm having the same problem.
  • I am crashing and can provide my crash report.

Versions

Minecraft 1.7.10
Forge 10.13.4.1566-1.7.10
RadixCore 1.7.10-2.1.2
MCA 1.7.10-5.2.0

Issue Description

Everytime I try to punch a Iron Golem, I crash. Your mod is doing something weird to vanilla villagers and golems when not overiding the vanilla villagers

Reproduce Steps

Turn off MCA villager override. Spawn in a Iron Golem. Spawn in a MCA Villager. Punch Golem, nothing happens. Spawn in a Vanilla Villager. Punch golem, crash.

Additional Information

crash-2016-07-08_10.36.46-client.txt

MCA Crash Log: https://pastebin.com/2ExWsQHy
MCA + RADIXCORE Only Crash Log:https://pastebin.com/q0TYLgDS

commented

Refined the issue. It only happens when turning OFF the villager overide and attacking a iron golem close to a vanilla villager. Determined that it is only MCA doing this. MCA 5.1.2 did NOT produce this error. The reason I like not overriding original villagers is the screams from MCA villagers in a TCon smeltery is not nice, whereas vanilla villagers does not spam the log with death messages. And it looks like this:
Villager Annihilation

EDIT: Happens when attacking anything, when villager overide is off. When it is on it crashes when any mod villager, e.g TCons Villager, and you hit it, it also crashes. Checked through your code and narrowed it down to this line https://github.com/WildBamaBoy/minecraft-comes-alive/blob/master/src/main/java/mca/core/forge/EventHooksForge.java#L254
It might be how you affect the player.
EDIT 2: Does NOT happen on MCA 5.1.2 for Minecraft 1.7.10, obviously due to the lack of villager changes. @WildBamaBoy hope this is easily solvable.
EDIT 3: This is happening on every version.

commented

Having the same issue as stated, normal vanilla villagers such as those added in by mods that MCA does not override will crash the game after hitting mobs if in the vicinity.
In my case I crashed from hitting a lycanite mob inside a villages walls, although with a tinkers construct broadsword.
crash-2016-07-08_22.39.40-server.txt