MCA Reborn [Fabric/Forge]

MCA Reborn [Fabric/Forge]

6M Downloads

Vanilla fallback translation feature is broken since 1.19.4

Patbox opened this issue ยท 0 comments

commented

Describe the bug
Minecraft 1.19.4 added a fallback field to translatable text. This mods mixin breaks it, by forcing usage of a key for both.
This breaks any server side mod and datapack using this feature, which is now commonly used.

To Reproduce
Steps to reproduce the behavior:

  1. Join a world, with cheats enabled.
  2. Type /tellraw @a {"translate":"broken.mess","fallback":"It works!"}
  3. See broken.mess being sent in chat instead of It works

Alternatively use mods using Server Translation API, such a GOML on server only.

Version
7.5.3+1.20.1, 1.20.1, Fabric (but should effect anything past 1.19.4 on all platforms).

Cause
https://github.com/Luke100000/minecraft-comes-alive/blob/1.20.1/common/src/main/java/net/mca/mixin/client/MixinTranslationStorage.java#L42
This mixin (or mod directly this line), causes it to break.
Ideally you should remove that line to allow mods/vanilla logic further down to modify it.

Initial report: Patbox/get-off-my-lawn-reserved#33