Immersive Vehicles (Formerly Transport Simulator)

Immersive Vehicles (Formerly Transport Simulator)

4M Downloads

v16.1 steal vehicle in multiplayer

dentesdracula opened this issue · 18 comments

commented

Hello . In multiplayer, player A owns a car, player B craft a new key and can unlock player A's car and steal it.
Thank you for mod

commented

Has Player A tried shift clicking his car with a key after pairing the key to the car by normally clicking on it? Doing so will make it so that Player B, Player J and even Player X can't take parts off of it or make new keys for it.

commented

Yes, we have done all these tests and player B has just re-craft a new key and player B can open a vehicle already closed by player A

commented

What do you mean by re-craft a key? Please detail the exact steps and every step you take with the keys. From the point you place down the vehicle, to the point you have your issue.

commented

I just tested this myself, they're saying it's possible to bypass security by linking a new key to a car, even if it's owned and shouldn't be possible

commented

Ah, and you can confirm that even if a vehicle is owned you can right-click the vehicle with a new key and you then get a key that works on that vehicle and can open it?

commented

1 Have each placed our vehicle
2 We each craft our key (a two iron string)
3 We click with the key on our vehicle for the locker
4 We test our keys on the two vehicles, and of course the keys do not allow to open the vehicle that does not belong to us.
5 We craft a new key to try to open the vehicle that is not ours, and the key allows to close and open the vehicle that is not ours.

Thank you and
Sorry for my english google trad ;-)

commented

Ah, and you can confirm that even if a vehicle is owned you can right-click the vehicle with a new key and you then get a key that works on that vehicle and can open it?

Yes i confirm :-)

commented

Rodger that. I'm well overdue for some major changes to how vehicle interaction is done, so expect this to come around in a few cycles. I first need to shore up the bug that got caused by the instrument key fix, and if I can't get this one fixed in that cycle, I'll have to push it till after I get the instruments fixed.

commented

Rodger that. I'm well overdue for some major changes to how vehicle interaction is done, so expect this to come around in a few cycles. I first need to shore up the bug that got caused by the instrument key fix, and if I can't get this one fixed in that cycle, I'll have to push it till after I get the instruments fixed.

Your mod is so cool that we will have to wait :-)
Thank you

commented

So when you use the new key, do you get a message about you not being the owner? And after that message, are you able to still unlock the vehicle with that new key?

commented

When testing this yes, it did toss a message saying it was not my vehicle. And then I could unlock the car with said key.
(I could not change ownership though.)

commented

Yup. That makes sense with what I saw in my code. If y'all could test V16.1.1 I think it's fixed in there.

commented

Hello I have just redone the tests with version 16.1.1 and the problem is still there.
For info there is no owner's message with the new key. The vehicle always unlocks with a new key. Sorry

commented

P.S Right clicking with the wrench no longer crashes my server ;-)

commented

Lors du test de ce oui, il a lancé un message disant que ce n'était pas mon véhicule. Et puis j'ai pu déverrouiller la voiture avec cette clé.
(Je ne pouvais cependant pas changer de propriétaire.)

With my tests I didn’t get this message. We have just locked and unlocked vehicle message

commented

Sorry I did the test again is all ok
sorry

commented

The vehicle locks correctly now and only the owner can access it Just to add that we should not be able to break the wheels of a vehicle that does not belong to us
Thank you for your responsiveness and for being super mod

commented

You're welcome! As to the wheel breakage, as mentioned in #324 that's per design as that's vehicle damage, and that can be inflicted by anyone on any vehicle regardless of ownership. Would be really odd if you shot a vehicle with a gun and you could only damage it if you were the owner.