crash with Sandwichable and Minekea
AnomalousDeity opened this issue ยท 7 comments
Describe the bug
a definite crash with the mod Sandwichable and Minekea
To Reproduce
Steps to reproduce the behavior:
- place a display case
- build a ridiculous Scooby doo size sandwich
- attempt to place inside display case
- crash
Expected behavior
honestly im not sure what to expect, I was horsing around testing mods before I load it onto a server, decided ya know what imma make a sandwich taller than my own character which I did several times then decided if I could display it, got out the display case expecting some broken looking rendering Or it not to work at all but I got a crash, but well worth a good laugh seeing my absurd construction
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
- Minecraft version: fabric 1.19
- Minekea version: 3.1.2
- OS: Windows 10
Additional context
works fine with item frames, ill give a screenshot of my absurd sandwich size for reference or good laughs if it helps any
I like to also mention if you do this either back up your world or roll back because you wont be able to load your world up without crashing
I don't even know what to say to this. I am simultaneously horrified and in awe. I have no idea why it would crash in a display case but not an item frame (I copied parts of the item frame code related to rendering). But I'll definitely see if it's something I can fix.
Thanks for the report (and the chuckle)!
heres the crash description if it helps as well honestly though I dont think the cases would be used to display the monstrous abomination that is my cursed sandwich but I also dont want to risk having to roll back to avoid corrupted worlds tho it was def fun finding this xD
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1922.method_8321(net.minecraft.class_2338)" because "view" is null
at io.github.foundationgames.sandwichable.blocks.SandwichBlock.method_9530(SandwichBlock.java:46)
at com.chimericdream.minekea.client.render.block.DisplayCaseBlockEntityRenderer.render(DisplayCaseBlockEntityRenderer.java:78)
at com.chimericdream.minekea.client.render.block.DisplayCaseBlockEntityRenderer.method_3569(DisplayCaseBlockEntityRenderer.java:30)
at net.minecraft.class_824.method_23079(class_824.java:90)
at net.minecraft.class_824.method_23081(class_824.java:79)
at net.minecraft.class_824.method_3554(class_824.java:104)
at net.minecraft.class_824.method_3555(class_824.java:79)
at net.coderbot.iris.pipeline.ShadowRenderer.renderBlockEntities(ShadowRenderer.java:549)
at net.coderbot.iris.pipeline.ShadowRenderer.renderShadows(ShadowRenderer.java:471)
at net.coderbot.iris.pipeline.newshader.NewWorldRenderingPipeline.renderShadows(NewWorldRenderingPipeline.java:644)
at net.minecraft.class_761.handler$elp000$iris$renderTerrainShadows(class_761.java:12033)
at net.minecraft.class_761.method_22710(class_761.java:1239)
at net.minecraft.class_757.method_3188(class_757.java:1039)
at net.minecraft.class_757.method_3192(class_757.java:816)
at net.minecraft.class_310.method_1523(class_310.java:1143)
at net.minecraft.class_310.method_1514(class_310.java:734)
at net.minecraft.client.main.Main.main(Main.java:237)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)