
Memory leak when using overlayVillagerInfo renderer
cythorg opened this issue · 4 comments
Whenever the overlayVillagerInfo
renderer is enabled there is a memory leak. If I had to guess it scales with the amount of villagers in close proximity, however that is pure speculation and would need more testing to confirm. Disabling the renderer halts the memory leak.
using openjdk 21
modlist:
minihud 1.21.1-0.32.50
malilib 1.21.1-0.21.0
fabric api 0.105.0-1.21.1
modmenu 11.0.3
can confirm!!! Was using minihud while 60 other mods were in a modpack, i thought on everything, but not on my beloved villager info overlay 😢
If i would guess, it's because either a villager info itself, or NBT getting written over itself(?) countless times in a row. Maybe somehow it's possible to set up a "max villagers amount", or enable NBTs to garbage collector. I'm not a programmer so i don't actually know :p
UPD. My prism launcher was not auto-updating the mod, because the update is not on a modrinth. I'll update it manually and check for memory leaks once again, maybe it's fixed, because in changelog villagerinfo was mentioned
Most of this problem should be fixed under the upcoming 0.32.57 release (It's not out yet) but the -sakura.X of it can be downloaded on my Github.
MaLiLib is also up to 0.21.7-sakura.4
can confirm!!! Was using minihud while 60 other mods were in a modpack, i thought on everything, but not on my beloved villager info overlay 😢
If i would guess, it's because either a villager info itself, or NBT getting written over itself(?) countless times in a row. Maybe somehow it's possible to set up a "max villagers amount", or enable NBTs to garbage collector. I'm not a programmer so i don't actually know :p
UPD. My prism launcher was not auto-updating the mod, because the update is not on a modrinth. I'll update it manually and check for memory leaks once again, maybe it's fixed, because in changelog villagerinfo was mentioned
Any results from your testing?
Issue has been identified as a problem in MaLiLib.
Fixed in sakura-ryoko/malilib/pull/52
I was unaware that this was not the active development branch when I submitted the issue, nonetheless many thanks to all involved.