Model Gap Fix

Model Gap Fix

17M Downloads

Some blocks have weird glitches when using Model Gap Fix

Timolino456 opened this issue ยท 26 comments

commented

oh no
image
Disabling your mod fixes this.

I tried going into my creative world and scrolling through the inventory to find other blocks that have this, but it seems like it only happens when they're actually placed.
My mod list is really large so I'm not sure wether giving you it is really helpful, but maybe you can make out a mod that definitely messes things up, so here you go anyway (I use PolyMC, so mods with .disbaled at the end are obviously disabled):
image

commented

Do you mean this?
image

commented

Could you reload your texture pack and tell me which size texture atlases it created? (it should log that)

commented

Yup Ty. I have published another version. I don't think it will fix anything tho

commented

It worked lol (please ignore bad building skills)

Using 1.4:
2022-09-24_16 31 18

Using 1.5:
2022-09-24_16 29 52

commented

Unbelievable, blind fix worked o.o

commented

Alright, this seems to be fixed. 1.5 is still missing on Modrinth though, btw.

commented

You definitely have something that's messing with them as it doesnt happen in vanilla only. Its either a mod that modifies pumpkin or some visual or shader mod. Any idea?

commented

What mod are those blocks from?

commented

They are normal vanilla pumpkins, grown from seeds.
Edit: you can also just place some with creative mode, they have the same problem.

commented

I did some testing by disabling one block of mods after another (alphabetically, starting at A) and it stopped doing this when disabling Enhanced Block Entities. I then disabled almost every mod, keeping only EBE and Model Gap Fix enabled; the pumpkins still looked normal. I then enabled Sodium and Iris and then stuff looked like this (this is sand):
2022-09-18_14 49 35
I then disabled Iris and everything looked normal again. When keeping Iris enabled and instead disabling EBE, everything look normal aswell.
Maybe you can do something with this information?

commented

I honestly can't make out any specific pattern here. I just placed down the lower half of the creative inventory building blocks menu, here it seems to have issues with sand, red sandstone and parts of normal sandstone, red nether bricks, red terracotta and reinforced deepslate (screenshot). Glowing blocks like sea lanterns, glowstone, pumpkin lanterns and normal lantern work fine.
It's also weird that in my first instance it was pumpkins, while they work fine with only those three mods enabled. It might not be a problem with specific blocks.
2022-09-18_16 40 30

commented

Thanks I'll do some testing with those mods. It's very weird that it now does that with sand and not pumpkins anymore

commented

So I've tryied replicating this myself but wasnt able to. I installed the mod, iris, and enhanced block entities and all blocks were displaying normally. This was on 1.18 btw. I did hot however test with an actual shaderpack on as I didnt have one. Does this only happen with a shaderpack on for you?

commented

I've tested that already and no, that didn't change anything. But what I did find out is that certain resourcepacks seem to "activate" this issue. I do have multiple resourcepacks on top of one another (I did here too because I simply made a copy of the PolyMC instance). Both the latest version of Stay True and a custom Vanilla Tweaks pack seem to activate it. When removing all resource packs, the issue is gone. The affected blocks also change depending on what packs are active, although I'm not sure whether the block's texture actually has to be edited in any of the packs in order to be affected.
Removed only two packs which both changed one wooden planks texture (note how the sand looks different now):
2022-09-19_19 03 18
Removed everything but Vanilla Tweaks:
2022-09-19_19 03 45
Only Stay True enabled (I didn't have this one activated in any of the screenshots before):
2022-09-19_19 05 50
No resource packs enabled:
2022-09-19_19 12 56

commented

What vanilla tweak pack are you using? I tried with stay true and it didn't do anything. Maybe it's something that happens when one has many texture packs? Could you try using just those 2 packs? Does it happen with only stay true aswell?

commented

The third screenshot in my previous comment was with only Stay True. The Vanilla Tweaks pack is custom made, but it isn't really needed to cause it. It doesn't matter if I use both packs or just one of them, it happens as soon as I have at least one of them activated.
I also just tried to create a brand new PolyMC instance and redownloaded the mods and packs, but it didn't make any difference, still the same problem...

commented

Damn that is so weird. Can you download texture dump mod and send me the texture Altas image it generates? I want to see if there is anything in common with the texture that have that issue

commented

I would, but that's a Forge mod, isn't it? Can't really replicate the issue when using Forge since the Enhanced Block Entities mod doesn't have a Forge version and using Rubidium+Oculus alone doesn't trigger the issue. Or will it work anyway?

commented

Oh sorry I thought it was on both loaders. Wack back to the drawing board I guess, I wish I could replicate this

commented

Keeping up a mod on 2 websites is hard. I forgot

commented

This bug seems to be back as of mod version 1.8. I just noticed that powered rails have the same kind of problem in my survival world, when disabling the mod it's normal again.

commented

I know it's some kind of weird interaction with oculus (I think, that shaders mod)

commented

Seems like this is a problem within Iris, not Model Gap Fix: image

commented

So glad to know they are aware of it and it's not something specific to this mod

commented

Bug is fixed from Iris' side and it no longer appears. This should be closed.

commented

Cool awesome