Model Gap Fix

Model Gap Fix

17M Downloads

The fix can cause artifacts & Suggestion for liquid support

Defetyre opened this issue ยท 12 comments

commented

The mod does nothing. There are still gaps in both modded and vanilla items and blocks.
2022-09-27_16 09 56
2022-09-27_16 09 23
2022-09-27_16 20 18
2022-09-27_15 54 39
2022-09-27_15 51 49
2022-09-27_15 52 06
2022-09-27_16 17 35

commented

New release made gaps smaller, but still didn't completely solved the problem
2022-10-09_16 21 30

commented

Config appears to be forge-only for now, I use fabric. Besides, I'm not sure if all people will be able to figure out how to use it, or even bother to try, as they would expect most mods to work right out of the box

commented

New release added a config so you can tweak those values to be the exact ones for your system

commented

Didn't have time to add on yesterday. It's in th latest update from today. Mod works right out of the box infact that was one of the goals. The fix is applied and the textures aren't stretched anymore. The tiny gaps that could appear are a different beast entirely (you can see that they happen on corners instead of on all sides and aren't as noticeable.not they get worse the more you move away from the texture center) and on some systems like mine don't even appear.

commented

I was about to go into it, but it seems that the new 1.7 version of this mod is actually a 1.5 in disguise (for fabric, that is).

Version

I cant find the config, and yes, I deleted the old version from mods.

commented

To add onto this if you do find better values that work for you please send so I can test and see if I can replace the current one si there won't be tiny gaps for more people

commented

Hm maybe i uploaded the wrong file...

commented

The mod is working, I can see it from your screenshots that the big gaps in the sides of the models are gone due to texture scaling being removed (check the bug description or look at a door hinge and you'll see). Those tiny ones on corners are an artifact of another tweak I added that tries to cover other very tiny gaps that can still appear due to rounding errors. This seem to vary on your configuration and it's either one or the other. I'll likely add a config so people can tweak that value to the perfect parameter that hides both

commented

So mod does nothing for liquids. Might look into it in the future but it's a different issue than this one as it affects the model itself not it's texture mapping like this one

commented

Well, now I feel bad for saying that your mod does nothing. I meant to say that something was disrupting it's work within my modpack, or for example it not working specifically on fabric, rather than claiming that it does nothing from technical side of things (which I know nothing about). But for some reason I didn't bothered to word it correctly, sorry for that.
Liquids are usually not a big deal, you can barely notice any gaps in vanilla ones. But as you can see on that black liquid from Yttr, it can be quite unpleasant in some cases (especially with high contrast between liquid and what's behind it and while moving). sadly, there are no solutions to this and I thought your mod could fix the issue since you mentioned it's working not just for items.
Anyway, thanks for your efforts and explanation, I hope your mod will go a long way and succeeds at helping people with this sort of issues

commented

Is there any progress with this?

commented

After installing 1.8 all the gaps are completely gone. Thank you

2022-10-13_18 50 10
2022-10-13_18 50 27