Modern Beta [Fabric]

Modern Beta [Fabric]

166k Downloads

[1.18 - 1.19] Allowing terrain modifications from datapack creators.

Cixon opened this issue · 7 comments

commented

Introduction:

Hello B3spectacled! I firstly need to say thank you for all the hard work on this project, you've certainly restored quite a lot of veteran player's nostalgia with this mod and I value your efforts and hope this mod receives the love it deserves.

Bug-Context:
So I like to use a mod called Deeper Oceans which as the title suggestions, makes regular oceans go down to around y=15, and deep oceans go down to around y=-25. Modern Beta is designed a particular way to where these ocean modifications cannot be injected, I believe.

Specs:
tested on 1.18.2 modern beta v4.0.3
cloth-config v6.4.90
fabric api v0.76.0
singleplayer mode [Pocket Edition world type]

Mod In Question: https://www.curseforge.com/minecraft/mc-mods/deeper-oceans

Results We're Looking For (vanilla worldgen):
Screenshot (299)

Bugged Results (MB - pocketedition worldgen):
Screenshot (294)

commented

Thanks. Yes that's correct, Modern Beta implements a custom terrain generator to handle world generation so Deeper Oceans would not be interacting with Modern Beta at all. Deeper Oceans is also closed source, so I wouldn't be able to add a workaround or some such for compatibility.

I understand. Is there anyway for you to allow modifications for datapacks? According to mod creator of DeeperOceans, their mod is really a datapack if you convert the .jar to .zip

comment here:
https://www.curseforge.com/projects/714177?comment=36

commented

Thanks. Yes that's correct, Modern Beta implements a custom terrain generator to handle world generation so Deeper Oceans would not be interacting with Modern Beta at all. Deeper Oceans is also closed source, so I wouldn't be able to add a workaround or some such for compatibility.

commented

have not tested on any other world type but pocket edition

commented

Thanks, I took a look at the enclosed data pack. Deeper Oceans modifies the vanilla noise functions, which Modern Beta does not use at all.

commented

Thanks, I took a look at the enclosed data pack. Deeper Oceans modifies the vanilla noise functions, which Modern Beta does not use at all.

I see. I hate to bother you but is there a guide I could follow to accomplish deeper oceans via datapack with your mod? I saw somewhere there’s was a pre-existing datapack for your mod for something but maybe this is not the same thing..

commented

Right now, this is not possible without sacrificing accuracy of the terrain above water.

commented

Right now, this is not possible without sacrificing accuracy of the terrain above water.

Late reply, I will rename this title so in the event you find a way to allow datapacker's to make edits such as Deeperoceans you can close it.