Modern Industrialization

Modern Industrialization

12M Downloads

Logging mundane stuff as server errors

klimacka opened this issue ยท 3 comments

commented

As a server owner, I find it difficult or at time impossible to work with console logs because of this mod.

When a player has something wrong with their automation, I don't need to know as the server operator.

Check this example excerpt of server log:

[10:28:25] [Server thread/ERROR] [Modern Industrialization/]: Discarding overflowing item 14 modern_industrialization:lignite_coal_ore, extracted from block at position BlockPos{x=-2355, y=86, z=649} in ResourceKey[minecraft:dimension / minecraft:overworld], accessed from east side
[10:28:28] [Server thread/ERROR] [Modern Industrialization/]: Discarding overflowing item 12 modern_industrialization:lignite_coal_ore, extracted from block at position BlockPos{x=-2355, y=86, z=649} in ResourceKey[minecraft:dimension / minecraft:overworld], accessed from east side

Now these only come in every 3 seconds or so. That is annoying but manageable, but other times, I had similar messages about discarded liquids pop into the log at the rate of 4+ per second. That makes it hard to follow anything else in the log as it scrolls furiously.

Please do not log this as error, but info/warning at most and please add an option to turn these messages completely off via config.
I can see how someone might use these messages to debug their in-game automation setup, but on a server this information is totally useless and harmful even as it makes following the logs difficult.

Mod version: v2.2.32
Platform: NeoForge v21.1.99
Minecraft (Java): v1.21.1
Modpack: Craftoria

commented

This is actually quite a problematic message because it means that items are getting voided from the game entirely. I don't want it to be swept under the rug. I do agree that these messages are currently impossible to diagnose though, so the next release MI v2.3.1 will include #1060, which should clearly state which mod is being problematic.

commented

Hi @Technici4n and thanks for the reply! I would still like to argue, than knowing some mod does something wrong would not help with the usability aspect of server log/console. The logs grow to the sizes of ~30 MBs per day. The normal rate (when these messages I would like voided are not present) is about 1 MB per day. And we only have 1 player doing MI currently.

Please reconsider the ability to mute those by a config flag. It would be very helpful. And if you point me to a donation page I would buy you a coffee/beer or three...

commented

Let's see how it goes with the 2.3.1 update. I hope that broken mods will get fixed eventually. I might also downgrade the error to a warning, and rate-limit the message. Probably won't be removing it entirely though.