Modern Industrialization

Modern Industrialization

4M Downloads

Pipe Priorities not working with Tech Reborn Tanks

duncanwebb opened this issue ยท 3 comments

commented

Version: Modern-Industrialization-0.4.0-alpha.10
Fabric API: 0.11.3

Not sure what the expected behaviour is, this is what happens. Using all MI tanks, then the flow works as expected.

using-tech-tank.mp4

Earlier, instead of the steel tank there was an automatic trash can and I wondered why the tech reborn tank wasn't getting filled.

The other behaviour that is different between MI tanks and TR tanks is what happens to the connection when a tank is dropped.

dropping-tanks.mp4

I like the behaviour of the tech reborn tank, if it is broken, then the connection is also broken.

Your mod is excellent, many thanks.

commented

I can't reproduce the former issue in 1.17, so I'll assume this is due to either a bad implementation in MI which has been fixed since, or an issue with the way fluids used to work in 1.16.

Regarding connections, the correct behavior is that the connection should be removed, but TR doesn't send a neighbor block update so MI can't know that the tank was removed. (TechReborn/TechReborn#2484)

However, keeping the connection might be better, I'll look into it.

Your mod is excellent, many thanks.

Thanks :)

commented

However, keeping the connection might be better, I'll look into it.

This behavior has been implemented, thanks for the suggestion!
You can read the commit message for more details.

commented

I think you are correct about a bug in TR, the tank behaviour is rather strange there are three modes, in, out and in/out (like your pipe connections). There is a redstone signal mode in the TC machines and when on the fluids are being pushed into the machine. The flow was faster when the direction is set compared to in/out mode.