ModernFix

ModernFix

79M Downloads

[1.19.2] Crash with Modern Fix + Canary + Effortless Building

Reshy opened this issue · 5 comments

commented

[23Jul2023 05:49:27.241] [pool-3-thread-1/FATAL] [mixin/]: Mixin apply failed canary.mixins.json:item.ItemStackMixin -> net.minecraft.world.item.ItemStack: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException @at("INVOKE") on net/minecraft/world/item/ItemStack::isEmptyRecalculate with priority 1000 cannot inject into net/minecraft/world/item/ItemStack::m_41617_()V merged by org.embeddedt.modernfix.common.mixin.bugfix.item_cache_flag.ItemStackMixin with priority 1000 [PREINJECT Applicator Phase -> canary.mixins.json:item.ItemStackMixin -> Prepare Injections -> -> redirect$zed000$isEmptyRecalculate(Lnet/minecraft/world/item/ItemStack;)Z -> Prepare]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @at("INVOKE") on net/minecraft/world/item/ItemStack::isEmptyRecalculate with priority 1000 cannot inject into net/minecraft/world/item/ItemStack::m_41617_()V merged by org.embeddedt.modernfix.common.mixin.bugfix.item_cache_flag.ItemStackMixin with priority 1000 [PREINJECT Applicator Phase -> canary.mixins.json:item.ItemStackMixin -> Prepare Injections -> -> redirect$zed000$isEmptyRecalculate(Lnet/minecraft/world/item/ItemStack;)Z -> Prepare]

image

Crash Log: https://pastebin.com/4fyZV7KC

(Note there's a secondary issue preventing loading with Effortless Building installed, but this crash happens before that step)

commented

This also can happen with Create in conjunction with integrated stronghold.

commented
commented

I confirmed by testing locally that this crash occurs when there is a missing dependency (see line 8 of your log) and should not occur if all mods are installed correctly. I'll improve ModernFix to avoid crashing in the next release.

commented

ModernFix is already disabling its fix when Canary is loaded, the issue here was that the disabling mechanism didn't work on Forge if there was a load error due to a missing dependency (since Forge provides an incomplete mod list in this scenario).

commented

The issue is that Canary and ModernFix both has the same itemstack caches bug fix, this issue is fixed in the latest Canary updates by disabling the same fix when ModernFix is loaded, I hope you have a good day!