ModernFix

ModernFix

Mods
2M Downloads

Not sure whats with that but, after updating ModernFix into 5.16.0 and made a spark test, modernfix seem to create TPS problems?

Fyoncle opened this issue · 5 comments

commented

Bug Description

Spark

I use Elysium Days modpack by the way.

Reproduction Steps

  1. Update ModernFix to 5.16.0
  2. Run around the map for like 5 minutes
  3. Type /spark profiler stop and check the Mods list

Log File

No need

commented

Please provide a link to the Spark profile.

Theres nothing special inside it, it doesn't provide any info.
Spark2

commented

LockSupport.parkNanos is called when the server is waiting between ticks; it doesn't indicate lag. This appears to be a false positive from Spark.

commented

LockSupport.parkNanos is called when the server is waiting between ticks; it doesn't indicate lag. This appears to be a false positive from Spark.

Oh, so its not any TPS issue at all but false? becuase i have been having tps issues on my modpack for a long while and cannot figure it out why, and when i saw ur mod all the way above after update it just looked weird.

commented

Please provide a link to the Spark profile.

commented

Yes, it is because I patch the code which calls LockSupport.parkNanos as of 5.16.0 (to fix a vanilla bug), which I guess causes Spark to falsely blame ModernFix for the time spent waiting. I think your other TPS issues are unrelated.

  • ❤️1