Dynamic Resources fails to load BuildCraft's pipe models.
StockiesLad opened this issue ยท 3 comments
Bug Description
Pipe models won't even have the missingno texture. It will be completely blank. I think buildcraft uses a custom renderer for it's pipes which is directly incompatible with dynamic resources.
NOTE: I'm aware that it's just a PR, but AlexILL has shown interest in it and even made a branch for it.
Reproduction Steps
Environment:
- Use a build from this PR: BuildCraft/BuildCraft#4726
- modernfix-forge-5.20.0+mc1.20.1.jar
- Enable Dynamic Resources in modernfix-mixins.properties
- Forge 47.3.22
Log File
The same happens with benches from SuperMartinJs Benched mod - with ModernFix Dynamic Resources enabled - benches become invisible in item form and when placed. When I disable Dynamic Resources - then the benches are rendered. ModernFix version is neoforge-5.20.3+mc1.21.4
The original issue should be fixed by now in the latest ModernFix release.
@Budzin I tested Benched on 1.21.1 with dynamic resources enabled, and it seems to work fine. I expect there to be various compatibility issues on 1.21.4 because of the numerous rewrites required due to Mojang's model changes. They have made even more changes since 1.21.4, so I'm likely not going to bother fixing those issues since I have to rewrite the whole system again anyway. I would recommend disabling dynamic resources if you intend to play 1.21.4 with mods using advanced models.
The original issue should be fixed by now in the latest ModernFix release.
@Budzin I tested Benched on 1.21.1 with dynamic resources enabled, and it seems to work fine. I expect there to be various compatibility issues on 1.21.4 because of the numerous rewrites required due to Mojang's model changes. They have made even more changes since 1.21.4, so I'm likely not going to bother fixing those issues since I have to rewrite the whole system again anyway. I would recommend disabling dynamic resources if you intend to play 1.21.4 with mods using advanced models.
Couldn't you make the exceptions list handled in the configs so one can disable problematic mods without turning the whole thing off?