ModernFix

ModernFix

93M Downloads

fail to load

al-wei opened this issue · 1 comments

commented

Bug Description

Sometimes loading the game will fail. But delete the modernfix folder to re-enter the game.
It is especially serious when mods increase or decrease. Almost 100%.
特别是对于mods增加或减少时,十分严重。几乎100%

Reproduction Steps

Delete the modernfix folder to access the game.

Log File

This is just one example. I don't know why it keeps happening.
java version 21.0.5
forge:36.2.42
modernfix-forge-5.18.0+mc1.16.5

https://mclo.gs/N3CUok0

commented

This appears to be a concurrency bug in EvilCraft when it initializes keybindings. These types of issues will only happen sometimes during the launch.

Caused by: java.lang.ExceptionInInitializerError: Exception java.util.ConcurrentModificationException [in thread "Worker-ResourceReload-3"]
	at java.base/java.util.HashMap.compute(HashMap.java:1325)
	at net.minecraftforge.client.settings.KeyBindingMap.addKey(KeyBindingMap.java:543)
	at net.minecraft.client.settings.KeyBinding.<init>(KeyBinding.java:89)
	at net.minecraft.client.settings.KeyBinding.<init>(KeyBinding.java:80)
	at org.cyclops.cyclopscore.client.key.KeyRegistry.newKeyBinding(KeyRegistry.java:34)
	at org.cyclops.evilcraft.client.key.Keys.<clinit>(Keys.java:20)

Unfortunately, ModernFix 1.16 is no longer receiving updates, but I would accept a PR from someone adding a patch for EvilCraft that fixes this issue.