Bug Description

Modernfix is taking a lot of ms on the server. With one or even two players, its not a big deal, but with 3+ its starting to be really noticible, any ideas? Thx<3

Reproduction Steps

Just casual gameplay

Mod list:
modernfix (v5.20.2+mc1.20.1)
Server thread54.87%
lithium (v0.11.3)
Server thread7.06%
fabric-data-attachment-api-v1 (v1.0.1+de0fd6d177)
Server thread3.34%
accessories (v1.0.0-beta.46+1.20.1)
Server thread2.94%
bclib (v3.0.14)
Server thread2.39%
cardinal-components-entity (v5.2.2)
Server thread2.39%
fallingtree (v4.3.4)
Server thread1.34%
crittersandcompanions (v2.2.2)
Server thread1.09%
aether (v1.5.2-beta.5)
Server thread0.95%
trinkets (v3.7.2)
Server thread0.82%
galosphere (v1.20.1-1.4.1)
Server thread0.59%
naturalist (v4.0.3)
Server thread0.57%
polymer-core (v0.5.19+1.20.1)
Server thread0.56%
fishofthieves (v3.0.10)
Server thread0.55%
debugify (v1.20.1+2.0)
Server thread0.46%
porting_lib_base (v2.3.9-beta.52+1.20.1)
Server thread0.44%
cinderscapes-common (v4.0.10)
Server thread0.44%
fabric-lifecycle-events-v1 (v2.2.22+1802ada577)
Server thread0.43%
brewery (v1.1.9)
Server thread0.42%
fabric-rendering-data-attachment-v1 (v0.3.37+92a0d36777)
Server thread0.35%
krypton (v0.2.3)
Server thread0.35%
morefrogs (v1.20.1-1.2.5-fabric)
Server thread0.31%
promenade (v4.1.1)
Server thread0.29%
puzzleslib (v8.1.25)
Server thread0.24%
framework (v0.6.16)
Server thread0.23%
customportalapi (v0.0.1-beta64-1.20)
Server thread0.23%
friendsandfoes (v3.0.7)
Server thread0.22%
polymer-virtual-entity (v0.5.19+1.20.1)
Server thread0.21%
onsoulfire (v1.20-2)
Server thread0.18%
servercore (v1.5.2+1.20.1)
Server thread0.17%
ferritecore (v6.0.1)
Server thread0.15%
immersive_melodies (v0.3.0+1.20.1)
Server thread0.14%
porting_lib_entity (v2.3.9-beta.52+1.20.1)
Server thread0.14%
balm-fabric (v7.3.18)
Server thread0.13%
immersive_optimization (v0.0.3)
Server thread0.09%
supplementaries (v1.20-3.1.20)
Server thread0.07%
immersive_aircraft (v1.20.1-DEV)
Server thread0.06%
horseman (v1.1.4)
Server thread0.06%
genshinstrument (v4.0.2)
Server thread0.06%
libertyvillagers (v1.0.15.1+fabric+1.20.1)
Server thread0.06%
starlight (v1.1.3-1.20.1+fabric.981937a)
Server thread0.05%
snowrealmagic (v10.6.1)
Server thread0.05%
spark (v1.10.53)
Server thread0.05%
libnetworkstack (v0.10.0-pre.2)
Server thread0.05%
connectiblechains (v2.2.1+1.20.1)
Server thread0.05%
netherexp (v2.1.3)
Server thread0.05%
wooledboots (v1.7)
Server thread0.04%
guardvillagers (v2.0.9-1.20.1)
Server thread0.04%
weaponmaster_ydm (v4.2.3)
Server thread0.04%
ecologics (v2.2.0)
Server thread0.04%
libblockattributes_items (v0.14.0-pre.1)
Server thread0.04%
skunk (v2.0.2)
Server thread0.04%
betterchunkloading (v1.20.1-5.4)
Server thread0.03%
animal_feeding_trough (v1.1.0+1.20.1)
Server thread0.03%
wetlands (v1.2)
Server thread0.03%
goblintraders (v1.9.3)
Server thread0.03%
porting_lib_attributes (v2.3.9-beta.52+1.20.1)
Server thread0.03%
horseshoes (v1.0.3)
Server thread0.03%
revive (v1.0.7)
Server thread0.03%
architectury (v9.2.14)
Server thread0.02%
doapi (v1.2.15)
Server thread0.02%
betterend (v4.0.11)
Server thread0.02%
packetfixer (v2.0.0)
Server thread0.02%
collective (v7.94)
Server thread0.02%
magnumtorch (v8.0.2)
Server thread0.02%
morebannerfeatures (v1.2.0)
Server thread0.02%
fwaystones (v3.3.2+mc1.20.1)
Server thread0.02%
smoothchunk (v1.20.1-4.0)
Server thread0.02%
dungeonnowloading (v1.5)
Server thread0.02%
villagernames (v8.2)
Server thread0.01%
limitedchunks (v1.20.1-4.1)
Server thread0.01%
appleskin (v2.5.1+mc1.20)
Server thread0.01%
beaconoverhaul (v1.8.4+1.20)
Server thread0.01%
variantsandventures (v1.0.6)
Server thread0.01%
betternether (v9.0.10)
Server thread0.01%
culinaire (v3.0.0)
Server thread0.01%
universal-graves (v3.0.3+1.20.1)
Server thread0.01%
giftsofgiving (v1.1.1)
Server thread0.01%
dummmmmmy (v1.20-2.0.6)
Server thread0.01%
fabricloader (v0.16.10)
Server thread0.01%
kambrik (v6.1.1+1.20.1)
Server thread0.01%
copper-horns (v1.0.2)
Server thread0.01%
farmersdelight (v1.20.1-2.3.0+refabricated)
Server thread0.01%
npcvariety (v2.3.0)
Server thread0.01%
linkart (v5.4.4-1.20.2-build.133)
Server thread0.01%
universalenchants (v8.0.0)
Server thread0.01%
fabric-content-registries-v0 (v4.0.12+1802ada577)
Server thread0.01%
visualoverhaul (v5.0.1)
Server thread0.01%
fabric-networking-api-v1 (v1.3.12+13a40c6677)
Server thread0.01%
fabric-recipe-api-v1 (v1.0.22+1802ada577)
Server thread0.01%
terrestria-common (v6.0.13)
Server thread0.01%
fabric-entity-events-v1 (v1.6.0+1c78457f77)
Server thread0.01%
letmedespawn (v1.4.4)
Server thread0.01%
server_translations_api (v2.0.0+1.20)
Server thread0.01%
Other
The following other mods are installed, but didn't show up in this profile. Yay!

adabranium (v2.5.1+1.20.1)
additionalstructures (v4.2.2)
adorn (v5.0.1+1.20.1)
advanced_runtime_resource_pack (v0.8.1)
advancednetherite (v2.1.3-1.20.1)
almanac (v1.0.2)
amplified_nether (v1.2.5)
andromeda (v1.13.3-1.20.1-build.104)
animal_armor_trims (v2.0.1)
applecrates (v3.0.1)
badpackets (v0.4.3)
badstdout (v1.1.1-1.20)
bambooeverything (v3.0.3+mc1.20.1)
basicshields (v1.4.1-1.20.2)
beautify (v1.2.0+1.20.1)
beenfo (v1.20-fabric0.83.0-1.3.3)
better-sign-edit (v1.1.1)
better_climbing (v3)
betterarcheology (v1.2.1-1.20.1)
betterdungeons (v1.20-Fabric-4.0.4)
betterjungletemples (v1.20-Fabric-2.0.5)
betterleads (v1.1.0+1.20.1)
bettermineshafts (v1.20-Fabric-4.0.4)
betteroceanmonuments (v1.20-Fabric-3.0.4)
bettersleeping (v0.6.2+1.19)
bettersleeping-core (v0.6.2)
betterstrongholds (v1.20-Fabric-4.0.3)
bettertridents (v8.0.1)
betterwitchhuts (v1.20-Fabric-3.0.3)
biolith (v1.0.0-beta.1)
blue_endless_jankson (v1.2.2)
bno (v9.1.1)
boatcontainer (v1.3.0)
boneequipment (v1.0.8)
bookshelf (v20.2.13)
bountiful (v6.0.4+1.20.1)
cardinal-components-base (v5.2.2)
cardinal-components-world (v5.2.2)
cauldron_dyeing (v1.0.11)
cavedust (v3.0.1)
chas (v1.20)
chimes (v2.0.1)
cinderscapes (v4.0.10)
cinderscapes-worldgen (v4.0.10)
cloth-basic-math (v0.6.1)
cloth-config (v11.1.136)
clumps (v12.0.0.4)
com_electronwill_night-config_core (v3.6.7)
com_electronwill_night-config_toml (v3.6.7)
com_eliotlash_mclib_mclib (v20)
com_velocitypowered_velocity-native (v3.2.0-SNAPSHOT)
common-protection-api (v1.0.0)
configapi (v1.20-2.3.2)
copperhopper (v0.5.1+1.20.1)
coppertools (v1.0.1)
crafter (v1.0.2-1.20.1)
craftingpad (v1.0.12)
cratedelight (v24.11.22-1.20-fabric)
creativecore (v2.12.24)
croptopia (v3.0.3)
crowdin-translate (v1.4+1.19.3)
cupboard (v1.20.1-2.7)
dark-matter-base (v4.1.0-1.20.1-build.86)
dark-matter-crash-handler (v4.1.0-1.20.1-build.86)
dark-matter-data (v4.1.0-1.20.1-build.86)
dark-matter-glitter (v4.1.0-1.20.1-build.86)
dark-matter-item-group (v4.1.0-1.20.1-build.86)
dark-matter-minecraft (v4.1.0-1.20.1-build.86)
dark-matter-mirage (v4.1.0-1.20.1-build.86)
dark-matter-mixin (v4.1.0-1.20.1-build.86)
dawn (v5.0.0)
dcintegration-fabric (v3.0.7)
de_erdbeerbaerlp_dcintegration_common (v3.0.7)
decorative_blocks (v4.1.3)
deeperdarker (v1.3.3)
display_case (v1.0.8)
doggomodoverhauled (v5.3.1)
easyanvils (v8.0.2)
easymagic (v8.0.1)
easyshulkerboxes (v8.0.2)
elytraslot (v6.4.4+1.20.1)
enchanter_fix (v1.1)
entityculling (v1.7.3)
epherolib (v1.2.0)
error_notifier (v1.0.9)
explorify (v1.6.2)
extensibleenums (v7.0.1)
fabric-api (v0.92.3+1.20.1)
fabric-api-base (v0.4.31+1802ada577)
fabric-api-lookup-api-v1 (v1.6.36+1802ada577)
fabric-biome-api-v1 (v13.0.13+1802ada577)
fabric-block-api-v1 (v1.0.11+1802ada577)
fabric-block-view-api-v2 (v1.0.1+1802ada577)
fabric-command-api-v1 (v1.2.34+f71b366f77)
fabric-command-api-v2 (v2.2.13+1802ada577)
fabric-commands-v0 (v0.2.51+df3654b377)
fabric-containers-v0 (v0.1.65+df3654b377)
fabric-convention-tags-v1 (v1.5.5+1802ada577)
fabric-crash-report-info-v1 (v0.2.19+1802ada577)
fabric-data-generation-api-v1 (v12.3.5+1802ada577)
fabric-dimensions-v1 (v2.1.54+1802ada577)
fabric-events-interaction-v0 (v0.6.3+13a40c6677)
fabric-events-lifecycle-v0 (v0.2.63+df3654b377)
fabric-game-rule-api-v1 (v1.0.40+1802ada577)
fabric-item-api-v1 (v2.1.28+1802ada577)
fabric-item-group-api-v1 (v4.0.13+1802ada577)
fabric-language-kotlin (v1.13.1+kotlin.2.1.10)
fabric-loot-api-v2 (v1.2.2+1802ada577)
fabric-loot-tables-v1 (v1.1.46+9e7660c677)
fabric-message-api-v1 (v5.1.9+1802ada577)
fabric-mining-level-api-v1 (v2.1.51+1802ada577)
fabric-networking-v0 (v0.3.52+df3654b377)
fabric-object-builder-api-v1 (v11.1.4+1802ada577)
fabric-particles-v1 (v1.1.2+1802ada577)
fabric-permissions-api-v0 (v0.3.1)
fabric-registry-sync-v0 (v2.3.4+1802ada577)
fabric-rendering-fluids-v1 (v3.0.28+1802ada577)
fabric-resource-conditions-api-v1 (v2.3.8+1802ada577)
fabric-resource-loader-v0 (v0.11.11+fb82e9d777)
fabric-screen-handler-api-v1 (v1.3.31+1802ada577)
fabric-transfer-api-v1 (v3.3.5+8dd72ea377)
fabric-transitive-access-wideners-v1 (v4.3.1+1802ada577)
fabricshieldlib (v1.7.2-1.20.1)
farmersknives (v3.2)
fastasyncworldsave (v1.20.1-2.3)
faster_entity_animations (v1.6)
feather_trampling (v1.0.2+1.20.1)
fiber (v0.23.0-2)
fishingreal (v1.20.1-1.7.2)
flesh2leather (v1.0.5+1.20.1)
forgeconfigapiport (v8.0.1)
formations (v1.0.3)
friendlyfire (v18.0.7)
geckolib (v4.7)
geophilic (v3.2)
getittogetherdrops (vfabric-1.20-1.3.1)
gpumemleakfix (v1.20.1-1.8)
hamsters (vfabric-1.0.3-1.20.1)
iceberg (v1.1.25)
inmis (v2.7.2-1.20.1)
inmisaddon (v1.0.4)
io_wispforest_endec (v0.1.8)
io_wispforest_endec_gson (v0.1.5)
io_wispforest_endec_netty (v0.1.4)
itemphysiclite (v1.6.6)
jamlib (v0.6.1+1.20.x)
java (v17)
jumpoverfences (v1.3.1)
kaffees_dual_ride (v1.1.0)
kanos_config (v0.4.1+1.14.4-1.19.4)
kirin (v1.15.6+1.20.1)
kiwi (v11.8.28+fabric)
kuma_api (v20.1.9-SNAPSHOT)
launchersmod (v3.2.2)
lazydfu (v0.1.3)
libblockattributes (v0.14.0-pre.1)
libblockattributes_core (v0.14.0-pre.1)
libblockattributes_fluids (v0.14.0-pre.1)
libmultipart (v0.11.0-pre.2)
libmultipart_compat (v0.11.0-pre.2)
llamasteeds (v2023.4.9)
magna (v${version})
masiks_puzzle_dungeon (v1.2.0)
mavapi (v1.1.4)
mavm (v1.2.6)
medieval_deco (v1.2)
medievalweapons (v1.4.8)
memory_cleaner (v1.0)
memoryleakfix (v1.1.5)
mes (v1.3.4-1.20-fabric)
midnightlib (v1.4.1)
minecraft (v1.20.1)
mixinextras (v0.4.1)
mixinsquared (v0.1.2-beta.6)
mm (v2.3)
mm_shedaniel (v2.4.1)
mo_glass (v1.7-MC1.20.1)
mob_catcher (v1.4.2)
monolib (v2.0.0)
moonlight (v1.20-2.13.71)
moreberries (v1.5.5)
morebows (v1.20-2.0.0)
moredelight (v25.1.13-1.20-fabric)
moremobs (v1.5.4+mod)
moretotems (v2.16.0)
morevillagers (v5.0.0)
mr_bft (v2.0.0)
mr_developer_resources (v0.2)
mr_ownership_improved (v1)
mr_tidal_towns (v1.3.4)
mr_villager_transportation (v1.3.1)
mru (v1.0.4+1.20.1+fabric)
nears (v2.1.2)
net_minecraftforge_eventbus (v6.0.3)
netheriteextras (v0.2.2+mc1.20.1)
netherportalfix (v13.0.2)
nethersdelight (v1.20.1-4.1.1)
nitrogen_internals (v1.20.1-1.0.15-fabric)
noisium (v2.3.0+mc1.20-1.20.1)
notenoughanimations (v1.9.2)
oceansdelight (vfdrf-fabric-1.0.2-1.20)
omega-config (v1.4.0+1.20.1)
org_apache_commons_commons-text (v1.9)
org_javassist_javassist (v3.29.2-GA)
org_jetbrains_kotlin_kotlin-reflect (v2.1.10)
org_jetbrains_kotlin_kotlin-stdlib (v2.1.10)
org_jetbrains_kotlin_kotlin-stdlib-jdk7 (v2.1.10)
org_jetbrains_kotlin_kotlin-stdlib-jdk8 (v2.1.10)
org_jetbrains_kotlinx_atomicfu-jvm (v0.27.0)
org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm (v1.10.1)
org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 (v1.10.1)
org_jetbrains_kotlinx_kotlinx-datetime-jvm (v0.6.1)
org_jetbrains_kotlinx_kotlinx-io-bytestring-jvm (v0.6.0)
org_jetbrains_kotlinx_kotlinx-io-core-jvm (v0.6.0)
org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm (v1.8.0)
org_jetbrains_kotlinx_kotlinx-serialization-core-jvm (v1.8.0)
org_jetbrains_kotlinx_kotlinx-serialization-json-jvm (v1.8.0)
org_mariuszgromada_math_mathparser_org-mxparser (v5.2.1)
org_reflections_reflections (v0.10.2)
org_yaml_snakeyaml (v2.2)
owo (v0.11.2+1.20)
packet_tweaker (v0.4.0+1.19.4)
pickupnotifier (v8.0.0)
ping-wheel (v1.10.1)
placeholder-api (v2.1.3+1.20.1)
polymer-common (v0.5.19+1.20.1)
polymer-networking (v0.5.19+1.20.1)
polymer-registry-sync-manipulator (v0.5.19+1.20.1)
polymer-resource-pack (v0.5.19+1.20.1)
porting_lib_accessors (v2.3.9-beta.52+1.20.1)
porting_lib_asm (v2.3.9-beta.51+1.20.1)
porting_lib_blocks (v2.3.9-beta.51+1.20.1)
porting_lib_brewing (v2.3.9-beta.51+1.20.1)
porting_lib_client_events (v2.3.9-beta.51+1.20.1)
porting_lib_common (v2.3.9-beta.52+1.20.1)
porting_lib_config (v2.3.9-beta.52+1.20.1)
porting_lib_core (v2.3.9-beta.52+1.20.1)
porting_lib_data (v2.3.9-beta.51+1.20.1)
porting_lib_extensions (v2.3.9-beta.52+1.20.1)
porting_lib_fluids (v2.3.9-beta.52+1.20.1)
porting_lib_gui_utils (v2.3.9-beta.52+1.20.1)
porting_lib_items (v2.3.9-beta.51+1.20.1)
porting_lib_lazy_registration (v2.3.9-beta.52+1.20.1)
porting_lib_level_events (v2.3.9-beta.51+1.20.1)
porting_lib_loot (v2.3.9-beta.51+1.20.1)
porting_lib_mixin_extensions (v2.3.9-beta.52+1.20.1)
porting_lib_model_generators (v2.3.9-beta.51+1.20.1)
porting_lib_model_loader (v2.3.9-beta.51+1.20.1)
porting_lib_model_materials (v2.3.9-beta.51+1.20.1)
porting_lib_models (v2.3.9-beta.51+1.20.1)
porting_lib_networking (v2.3.9-beta.51+1.20.1)
porting_lib_recipe_book_categories (v2.3.9-beta.51+1.20.1)
porting_lib_tags (v3.0)
porting_lib_tool_actions (v2.3.9-beta.52+1.20.1)
porting_lib_transfer (v2.3.9-beta.52+1.20.1)
porting_lib_utility (v2.3.9-beta.52+1.20.1)
predicate-api (v0.2.1+1.20.1)
projectiles (v1.0.0)
promenadedelight (v1.0.1-1.20.1)
puzzlesaccessapi (v8.0.9)
puzzlesapi (v8.1.6)
reach-entity-attributes (v2.4.0)
recipecooldown (v1.17.1-1.0.0)
redirector (v1.20.1-4.4.0)
ribbits (v1.20.1-Fabric-3.0.4)
rightclickharvest (v3.2.3+1.19.x-1.20.1-fabric)
roughlyenoughitems (v12.1.785)
sawmill (v1.20-1.4.6)
sculk_expansion_mr (v1.3.2)
sgui (v1.2.2+1.20)
simple_pipes (v0.11.0-pre.2)
simple_pipes_dep_container (v0.11.0-pre.2)
smarterfarmers (v1.20-2.1.0)
smoke_signals (v1.0)
smoothmenu (v1.1.0)
sneak_through_berries (v8.0.0+1.20.1)
snifferplus (v0.3.0)
snuffles (v1.0.0+1.20)
space_arim_dazzleconf_dazzleconf-core (v1.3.0-M2)
space_arim_dazzleconf_dazzleconf-ext-snakeyaml (v1.3.0-M2)
spawnanimations (v1.10+mod)
spyglass-improvements (v1.5.1+mc1.20+fabric)
statement (v4.2.9+1.14.4-1.20.4)
statement_vanilla_compatibility (v1.0.1+1.16.5-1.17)
static-content (v1.0.2-1.16.2)
staticdata (v1.1.2)
stoneholm (v2.0.0)
stoneworks (v8.0.0)
storagedelight (v24.12.15-1.20-fabric)
structory (v1.3.5)
supermartijn642configlib (v1.1.8+a)
supermartijn642corelib (v1.1.18+a)
terrablender (v3.0.1.7)
terraform-biome-remapper-api-v1 (v7.0.3)
terraform-config-api-v1 (v7.0.3)
terraform-dirt-api-v1 (v7.0.3)
terraform-shapes-api-v1 (v7.0.3)
terraform-surfaces-api-v1 (v7.0.3)
terraform-tree-api-v1 (v7.0.3)
terraform-wood-api-v1 (v7.0.3)
terralith (v2.5.4)
terrestria (v6.0.13)
terrestria-worldgen (v6.0.13)
thecopperrail (v0.9.1)
toofast (v1.2.0)
traverse (v7.0.12)
traverse-common (v7.0.12)
traverse-worldgen (v7.0.12)
u_desert (v1.3.1)
universalbonemeal (v8.0.1)
vanilla-hammers (v3.5.0+gnifty3-1.20.1)
variantchiseledbookshelves (v1.3.8)
veggie_way (v1.5.4)
villager-hats (v1.6.2+1.20)
villagesandpillages (v1.0.2)
visualworkbench (v8.0.0)
walllanterns (v1.6.1+1.20.1)
wandering_trader_tradesfabric (v1.0.0)
wthit (v8.16.1)
wunderlib (v1.1.5)
yet_another_config_lib_v3 (v3.6.3+1.20.1-fabric)
yungsapi (v1.20-Fabric-4.0.6)
yungsextras (v1.20-Fabric-4.0.3)

Log File

latest.log

There are two primary issues here:

• The server is indeed idling for lots of time (46%) which falsely gets attributed to ModernFix.
• You have datapacks or MCreator mods installed that run commands involving the @e[nbt={..}] type of entity selector. This requires every entity in the world to be serialized to NBT on every tick, which is extremely expensive. Since ModernFix includes patches around NBT code, it gets blamed for the time spent manipulating NBT, even though the primary cause of that is actually the vanilla command.

Measuring the relative TPS consumption of a performance mod using Spark is not reliable, as the performance mod by definition replaces parts of Minecraft's code, meaning it will get blamed for issues caused by other mods. Additionally, Spark tends to attribute server idle time to ModernFix as well for some reason. Would need to see the whole Spark profile to have an idea of what is going on here.

Ok, thx for the info <3. But just in case, Im adding a spark profile. I would appreciate it if you could give me additional information.
https://spark.lucko.me/UDOYvEDaNY

Ok, thx for info<3