ModernFix

ModernFix

93M Downloads

[1.21.4+] dynamic_entity_renderers is broken

Poopooracoocoo opened this issue ยท 1 comments

commented

Bug Description

Hangs on Mojang splash screen

Reproduction Steps

  1. Launch game with ModernFix and Entity View Distance and with ModernFix's dynamic_entity_renderers set to true

Log File

latest.log

Details
[08:56:54] [main/INFO]: Loading Minecraft 1.21.4 with Fabric Loader 0.16.10
[08:56:54] [main/WARN]: Skipping missing system property provided mod path C:\Users\anon\AppData\Roaming\PrismLauncher\instances\test\minecraft\mods\og
[08:56:54] [main/INFO]: Loading 55 mods:
	- entity-view-distance 1.4.0+1.21.4
	   \-- fabric-permissions-api-v0 0.3.3
	- fabric-api 0.119.0+1.21.4
	   |-- fabric-api-base 0.4.54+b47eab6b04
	   |-- fabric-api-lookup-api-v1 1.6.86+b1caf1e904
	   |-- fabric-biome-api-v1 15.0.6+b1c29d8e04
	   |-- fabric-block-api-v1 1.0.31+7feeb73304
	   |-- fabric-block-view-api-v2 1.0.20+9c49cc8c04
	   |-- fabric-blockrenderlayer-v1 2.0.8+7feeb73304
	   |-- fabric-client-tags-api-v1 1.1.29+20ea1e2304
	   |-- fabric-command-api-v1 1.2.62+f71b366f04
	   |-- fabric-command-api-v2 2.2.41+e496eb1504
	   |-- fabric-commands-v0 0.2.79+df3654b304
	   |-- fabric-content-registries-v0 9.1.19+25d1a67604
	   |-- fabric-convention-tags-v1 2.1.19+7f945d5b04
	   |-- fabric-convention-tags-v2 2.14.0+a5c5487b04
	   |-- fabric-crash-report-info-v1 0.3.6+7feeb73304
	   |-- fabric-data-attachment-api-v1 1.6.2+e99da0f704
	   |-- fabric-data-generation-api-v1 22.3.0+0f4e5f5504
	   |-- fabric-dimensions-v1 4.0.10+7feeb73304
	   |-- fabric-entity-events-v1 2.0.15+62245bef04
	   |-- fabric-events-interaction-v0 4.0.4+a4eebcf004
	   |-- fabric-game-rule-api-v1 1.0.63+7d48d43904
	   |-- fabric-item-api-v1 11.3.0+ee91fa1f04
	   |-- fabric-item-group-api-v1 4.2.2+fcb9601404
	   |-- fabric-key-binding-api-v1 1.0.57+7d48d43904
	   |-- fabric-keybindings-v0 0.2.55+df3654b304
	   |-- fabric-lifecycle-events-v1 2.5.4+bf2a60eb04
	   |-- fabric-loot-api-v2 3.0.38+3f89f5a504
	   |-- fabric-loot-api-v3 1.0.26+203e6b2304
	   |-- fabric-message-api-v1 6.0.25+7feeb73304
	   |-- fabric-model-loading-api-v1 4.3.0+ae23723504
	   |-- fabric-networking-api-v1 4.4.0+db5e668204
	   |-- fabric-object-builder-api-v1 18.0.14+38b0d59804
	   |-- fabric-particles-v1 4.0.14+7feeb73304
	   |-- fabric-recipe-api-v1 8.1.1+640e77ae04
	   |-- fabric-registry-sync-v0 6.1.11+4a9c1ece04
	   |-- fabric-renderer-api-v1 5.0.3+50f0feb204
	   |-- fabric-renderer-indigo 2.0.3+50f0feb204
	   |-- fabric-rendering-data-attachment-v1 0.3.58+73761d2e04
	   |-- fabric-rendering-fluids-v1 3.1.19+7feeb73304
	   |-- fabric-rendering-v1 10.2.1+0d31b09f04
	   |-- fabric-resource-conditions-api-v1 5.0.13+203e6b2304
	   |-- fabric-resource-loader-v0 3.1.1+360374ac04
	   |-- fabric-screen-api-v1 2.0.38+7feeb73304
	   |-- fabric-screen-handler-api-v1 1.3.118+7feeb73304
	   |-- fabric-sound-api-v1 1.0.32+7feeb73304
	   |-- fabric-tag-api-v1 1.0.7+7d48d43904
	   |-- fabric-transfer-api-v1 5.4.9+efa825c904
	   \-- fabric-transitive-access-wideners-v1 6.3.2+56e78b9b04
	- fabricloader 0.16.10
	   \-- mixinextras 0.4.1
	- java 21
	- minecraft 1.21.4
	- modernfix 5.20.3+mc1.21.4
[08:56:54] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.7 Source=file:/C:/Users/anon/AppData/Roaming/PrismLauncher/libraries/net/fabricmc/sponge-mixin/0.15.4+mixin.0.8.7/sponge-mixin-0.15.4+mixin.0.8.7.jar Service=Knot/Fabric Env=CLIENT
[08:56:54] [main/INFO]: Compatibility level set to JAVA_16
[08:56:54] [main/INFO]: Compatibility level set to JAVA_21
[08:56:55] [main/INFO]: Loaded configuration file for ModernFix 5.20.3+mc1.21.4: 54 options available, 1 override(s) found
[08:56:55] [main/WARN]: Option 'mixin.perf.dynamic_entity_renderers' overriden (by user configuration) to 'true'
[08:56:55] [main/INFO]: Applying Nashorn fix
[08:56:55] [main/INFO]: Initializing MixinExtras via com.llamalad7.mixinextras.service.MixinExtrasServiceImpl(version=0.4.1).
[08:56:56] [Datafixer Bootstrap/INFO]: 243 Datafixer optimizations took 330 milliseconds
[08:56:56] [main/WARN]: Invalid registry value type detected for PerfOS counters. Should be REG_DWORD. Ignoring: HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\PerfOS\Performance\Disable Performance Counters.
[08:57:00] [main/INFO]: Vanilla bootstrap took 3380 milliseconds
[08:57:00] [Render thread/INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD]
[08:57:00] [Render thread/INFO]: Setting user: anon
[08:57:00] [Render thread/INFO]: [Indigo] Registering Indigo renderer!
[08:57:01] [Render thread/INFO]: Backend library: LWJGL version 3.3.3-snapshot
[08:57:02] [Render thread/INFO]: Invalidating pack caches
[08:57:02] [Render thread/INFO]: Reloading ResourceManager: vanilla, fabric, entity-view-distance, fabric-api, fabric-api-base, fabric-api-lookup-api-v1, fabric-biome-api-v1, fabric-block-api-v1, fabric-block-view-api-v2, fabric-blockrenderlayer-v1, fabric-client-tags-api-v1, fabric-command-api-v1, fabric-command-api-v2, fabric-commands-v0, fabric-content-registries-v0, fabric-convention-tags-v1, fabric-convention-tags-v2, fabric-crash-report-info-v1, fabric-data-attachment-api-v1, fabric-data-generation-api-v1, fabric-dimensions-v1, fabric-entity-events-v1, fabric-events-interaction-v0, fabric-game-rule-api-v1, fabric-item-api-v1, fabric-item-group-api-v1, fabric-key-binding-api-v1, fabric-keybindings-v0, fabric-lifecycle-events-v1, fabric-loot-api-v2, fabric-loot-api-v3, fabric-message-api-v1, fabric-model-loading-api-v1, fabric-networking-api-v1, fabric-object-builder-api-v1, fabric-particles-v1, fabric-recipe-api-v1, fabric-registry-sync-v0, fabric-renderer-api-v1, fabric-renderer-indigo, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-rendering-v1, fabric-resource-conditions-api-v1, fabric-resource-loader-v0, fabric-screen-api-v1, fabric-screen-handler-api-v1, fabric-sound-api-v1, fabric-tag-api-v1, fabric-transfer-api-v1, fabric-transitive-access-wideners-v1, fabricloader, modernfix
[08:57:02] [Worker-ResourceReload-3/INFO]: Found unifont_all_no_pua-16.0.01.hex, loading
[08:57:02] [Worker-ResourceReload-8/INFO]: Found unifont_jp_patch-16.0.01.hex, loading
[08:57:03] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Realtek HD Audio 2nd output (Realtek(R) Audio)
[08:57:03] [Render thread/INFO]: Sound engine started
[08:57:03] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas
[08:57:03] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas
[08:57:03] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[08:57:03] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[08:57:03] [Render thread/INFO]: Created: 2048x1024x4 minecraft:textures/atlas/armor_trims.png-atlas
[08:57:03] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas
[08:57:03] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[08:57:03] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[08:57:03] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[08:57:03] [Render thread/INFO]: Created: 64x64x0 minecraft:textures/atlas/map_decorations.png-atlas
[08:57:03] [Render thread/INFO]: Dynamic entity renderer hook setup
[08:57:03] [Render thread/INFO]: Caught error loading resourcepacks, removing all selected resourcepacks
java.util.concurrent.CompletionException: java.lang.ClassCastException: class java.util.IdentityHashMap cannot be cast to class org.embeddedt.modernfix.entity.EntityRendererMap (java.util.IdentityHashMap is in module java.base of loader 'bootstrap'; org.embeddedt.modernfix.entity.EntityRendererMap is in unnamed module of loader 'knot' @568bf312)
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:791) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
	at knot/net.minecraft.class_4014.method_18365(class_4014.java:68) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_1255.method_18859(class_1255.java:164) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_4093.method_18859(class_4093.java:23) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_1255.method_16075(class_1255.java:138) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_1255.method_5383(class_1255.java:123) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1523(class_310.java:1296) [client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1514(class_310.java:922) [client-intermediary.jar:?]
	at knot/net.minecraft.client.main.Main.main(Main.java:267) [client-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.10.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.10.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.10.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:105) [NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) [NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?]
Caused by: java.lang.ClassCastException: class java.util.IdentityHashMap cannot be cast to class org.embeddedt.modernfix.entity.EntityRendererMap (java.util.IdentityHashMap is in module java.base of loader 'bootstrap'; org.embeddedt.modernfix.entity.EntityRendererMap is in unnamed module of loader 'knot' @568bf312)
	at knot/net.minecraft.class_898.redirect$bac000$modernfix$setRendererField(class_898.java:1044) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_898.method_14491(class_898.java:456) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_4013.method_29490(class_4013.java:16) ~[client-intermediary.jar:?]
	at java.base/java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:787) ~[?:?]
	... 15 more
[08:57:03] [Render thread/INFO]: Invalidating pack caches
[08:57:03] [Render thread/INFO]: Reloading ResourceManager: vanilla, fabric, entity-view-distance, fabric-api, fabric-api-base, fabric-api-lookup-api-v1, fabric-biome-api-v1, fabric-block-api-v1, fabric-block-view-api-v2, fabric-blockrenderlayer-v1, fabric-client-tags-api-v1, fabric-command-api-v1, fabric-command-api-v2, fabric-commands-v0, fabric-content-registries-v0, fabric-convention-tags-v1, fabric-convention-tags-v2, fabric-crash-report-info-v1, fabric-data-attachment-api-v1, fabric-data-generation-api-v1, fabric-dimensions-v1, fabric-entity-events-v1, fabric-events-interaction-v0, fabric-game-rule-api-v1, fabric-item-api-v1, fabric-item-group-api-v1, fabric-key-binding-api-v1, fabric-keybindings-v0, fabric-lifecycle-events-v1, fabric-loot-api-v2, fabric-loot-api-v3, fabric-message-api-v1, fabric-model-loading-api-v1, fabric-networking-api-v1, fabric-object-builder-api-v1, fabric-particles-v1, fabric-recipe-api-v1, fabric-registry-sync-v0, fabric-renderer-api-v1, fabric-renderer-indigo, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-rendering-v1, fabric-resource-conditions-api-v1, fabric-resource-loader-v0, fabric-screen-api-v1, fabric-screen-handler-api-v1, fabric-sound-api-v1, fabric-tag-api-v1, fabric-transfer-api-v1, fabric-transitive-access-wideners-v1, fabricloader, modernfix
[08:57:03] [Worker-ResourceReload-6/INFO]: Found unifont_all_no_pua-16.0.01.hex, loading
[08:57:03] [Worker-ResourceReload-2/INFO]: Found unifont_jp_patch-16.0.01.hex, loading
[08:57:04] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Realtek HD Audio 2nd output (Realtek(R) Audio)
[08:57:04] [Render thread/INFO]: Sound engine started
[08:57:04] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas
[08:57:04] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas
[08:57:04] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[08:57:04] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[08:57:04] [Render thread/INFO]: Created: 2048x1024x4 minecraft:textures/atlas/armor_trims.png-atlas
[08:57:04] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas
[08:57:04] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[08:57:04] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[08:57:04] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[08:57:04] [Render thread/INFO]: Created: 64x64x0 minecraft:textures/atlas/map_decorations.png-atlas
[08:57:04] [Render thread/INFO]: Dynamic entity renderer hook setup
[08:57:04] [Render thread/WARN]: Game took 10.486 seconds to start
[08:57:24] [Render thread/INFO]: Stopping!

Off topic but I found that the Remarkably Optimized modpack enables this ModernFix option smh.

commented

The issue seems exclusive to 1.21.4 (I checked on 1.21.1 and it doesn't seem to crash), so I'm unlikely to fix it until I port to a newer version. I'd suggest not using dynamic_entity_renderers for the time being.