ModernFix

ModernFix

93M Downloads

Fast growing log files and stuck loading with dynamic resources when installed with Fuzs's diagonal mods and more

eligibbs opened this issue ยท 8 comments

commented

Bug Description

Updating my pack after a while, I've developed an issue with dynamic resources, and have tried the 3 extensions off. Log file gets populated whiith hundreds of thousands of lines similar to:

[21:44:39] [Worker-ResourceReload-2/WARN]: Exception loading blockstate definition: 'quark:blockstates/raw_iron_bricks_wall.json' missing model for variant: 'quark:raw_iron_bricks_wall#east=tall,north=none,south=tall,up=true,waterlogged=true,west=none'

And the game never loads. Disable dynamic resources, and things are okay. A CF pack (with dynamic resources turned off) and a latest.log has been included that has the problem

PTR-0.21.0-beta.zip

There are frequent lines
[21:44:33] [Worker-ResourceReload-2/WARN]: Block 'chipped:vined_iron_bars' is using incompatible model 'net.minecraft.client.renderer.block.model.BlockModel' and should be added to the 'diagonalwindows:non_diagonal_windows' block tag. The model will not appear correctly under some circumstances!

that mention diagonal windows/fences/walls and I have tested without those mods, and the pack loads, but all textures are missing. I will be testing a bit further (outside my pack), will update with results on that. These mods did work fine a couple months ago within this pack

Reproduction Steps

Use CF pack, and enable dynamic resources. Test with out diagonal walls/windows/fences

Log File

2025-05-17-7.log

commented

Someone also just opened #552 with similar-sounding symptoms

commented

I do also have lightmans currency. I'll test that first

commented

It may be worth trying 5.21.0 as well - there was a change in 5.22 that lets more mods see the whole model registry, but badly programmed mods can then try to load every model during startup because of that. If the issue only happens in 5.22 it's most likely that and I can try to add more diagnostics to detect that situation.

I'll try to look into this myself as well tomorrow if I get some time.

commented

I'll give 5.21 a try. Diagonal mods load fine with modernfix alone, so its very weird. I'll update again in a bit

commented

Ok, so it's probably the same issue as #552 then, in which case fixing it will be a massive pain if it has to be done from my side. Recommended workaround would be to stick to 2.2.5.1c for now.

commented

I tried with chipped and quark, and log didn't file up, game has textures. Lightmans currency off the bat filled the log with those entries and game is texture-less. Testing downgrade of lightman's currency to confirm

commented

2.2.5.2a and 2.2.5.2 have the issue, 2.2.5.1c loads fine for forge 1.20.1 47.4.0

commented

Confirmed my pack is working with downgrade, closing as duplicate even though I was first as #552 looks better to work from