Crashed when stitching big textures
tkp30 opened this issue ยท 1 comments
Bug Description
When using reimplemented texture stitching algorithm with a lot of (big) textures, the game crashed with invaild memory access. In vanilla, the game's behavior should be removing all resourcepacks and report an error but not to crash.
According to the log, this may because the algorithm ignored max stitching texture size and tried to create big stitching (32768x16384x0), then visited wrong VRAM area. This only happens on Core GPUs because their dedicated VRAM is smaller than others. Seems like Minecraft doesn't like shared VRAM in these kind of GPUs, as the VRAM analyzing showed that it never rises to an unexpected level and there's a lot of free.
I've tried replacing GL options in Blaze3D to force enable GL Compression, but failed because of textures away. Maybe you can study it deeper and implement it as another external option.
P.S.: Don't tell me to remove mods or resourcepacks, or change a computer. They're necessary and I've optimized them as possible as I can. My computer is new.
Reproduction Steps
- Install many mods and resourcepacks with lots of textures (especially 64x+)
Log File
This issue was fixed by 7e9ace3, but that commit was not applied to 1.19.4 as it wasn't supported anymore at that time. I only provide long-term support for Minecraft versions that have an active modding scene.
I recommend upgrading to 1.20.1 or downgrading to 1.19.2 for the best experience. (Note that 1.19.2 is not supported anymore either, but it was supported long enough to get this fix.)