A suggestion for ModernFix and various other similar mods
Sunconure11 opened this issue · 1 comments
I had found that it is, in fact, possible to pull the packet limit entirely. Not bump it. Remove. However, I only have one example of a mod that does such to go off on.
As this would apply to multiple mods, not just ModernFix, would it be possible to bring this here?
As for the mod in question…
https://www.curseforge.com/minecraft/mc-mods/robins-unlimited-packets
However, this mod is closed source. You may need to crack its guts open to see what it does. I would also advise having the setting off by default.
Unrelated to this, there is a bug with ArchaicFix I’ve been having for two weeks straight.
I do not plan to implement this. The packet limit has a good reason to exist: it prevents security issues. As a simple example, some mods may have a very inefficient packet handler on the server. The inefficiency may allow a malicious actor to cause excessive server lag if sending an oversized packet of that type. There are other possible exploits a removed packet limit could reveal but I won't elaborate on them for obvious reasons.
Existing solutions to mitigate the packet limit usually only do it on specific packets that are known to become large in normal gameplay (e.g. the recipe packet) and usually only for the server->client direction, which is less of an issue. There are also already at least 2-3 such mods, so I don't see a benefit to implementing my own version of that more limited feature.
It would be reasonable to remove the packet limit in singleplayer, since in that case the client & server are both trustworthy to one another, but I generally don't like implementing hacks to hide problems in singleplayer only, if a better solution exists. In most cases packet size issues should be solved by patching the mod sending big packets, not by raising the limit.
Unrelated to this, there is a bug with ArchaicFix I’ve been having for two weeks straight.
I received the notification of the GitHub issue being opened as well as the several pings in various places . However, I work on several different modding projects, with very limited spare time compared to a few years ago, and ArchaicFix is not a top priority at this point. The issue has been left open to indicate it's still under consideration, and anyone is welcome to submit a PR if they want it fixed sooner.