ModernFix

ModernFix

72M Downloads

Passable Foliage Incompatibility?

wanji404 opened this issue · 11 comments

commented

Adding this ModernFix resulted in Passable Foliage not working anymore?
link:https://www.curseforge.com/minecraft/mc-mods/passable-foliage
Minecraft version:1.18.2forge
ModernFix version:2.5.2forge

commented

With only ModernFix and Passable Foliage installed everything appears to work normally.

commented

1.16.5, cannot reproduce this incompatibility too

commented

The dev build works on 1.19.2 as well. Thanks for the quick fix (also the mod is pretty awesome by itself)

commented

I experience the similar issue. After painstakingly disabling most of my mods i figured out that after number of loaded mods grows to 94 (counter in minecraft main menu) suddenly leaves become solid. I will test several configurations of this to determine if mod amount have anything to do with it and post it later. And possibly report it to passable foliage github

commented

It's most likely an incompatibility with the mixin.perf.reduce_blockstate_cache_rebuilds option in ModernFix, if you wish to test disabling that.

commented

It's most likely an incompatibility with the mixin.perf.reduce_blockstate_cache_rebuilds option in ModernFix, if you wish to test disabling that.

Yes, it seems to be the issue. Tested it with 94 and my own modpack of over 300. I wonder why the magic number is 94 though or why it happens. Leaves are passable now with disabling the mixin.perf.reduce_blockstate_cache_rebuilds
edit: also client: minecraft 1.19.2 forge 43.2.11 modernfix 3.5.2 passable foliage 5.2.0

commented

Please re-enable the option and test with the latest development build (link is in the README); this should be fixed now.

commented

Yes, it fixed the problem. Thank you

commented

Hm. Modify with MixinExtras will provide more compatibility I think

commented

I've already adjusted the mixin for better compatibility in the current dev builds.

commented

Fixed in latest releases.