Mod Menu

When clicking the website and issues buttons for a mod, the link confirmation shows the "Never open links from people you don't trust!" warning used for links placed in chat and the like. Given that installing a mod in the first place already requires putting a large amount of trust in the author, this seems rather meaningless. There's another version of the link confirmation without the red text (used for non-user provided links like the bugs/feedback buttons) which should probably be used instead.

Note that the fix to this issue is to change the linkTrusted argument in the ConfirmLinkScreen constructor to true:

ModMenu/src/main/java/com/terraformersmc/modmenu/gui/widget/DescriptionListWidget.java

Lines 326 to 331 in 0b88e0a

    
           client.setScreen(new ConfirmLinkScreen((open) -> { 
        
           	if (open) { 
        
           		Util.getOperatingSystem().open(link); 
        
           	} 
        
           	client.setScreen(parent); 
        
           }, link, false));

	client.setScreen(new ConfirmLinkScreen((open) -> {
	if (open) {
	Util.getOperatingSystem().open(link);
	}
	client.setScreen(parent);
	}, link, false));

Share to