"tr7zw Library Modules" not shown as a library
jacopobono8 opened this issue ยท 6 comments
"tr7zw Library Modules" is an embedded library for tr7zw's mods and it's a parent mod of TRansition and TRender (both shown as libraries), but this mod is not flagged as a library.
This is how the mod menu shows the mod when "show libraries" is turned on:
This is how the mod menu shows the mod when "show libraries" is turned off:
Probably this mod is counted in the mod number also when the "count libraries" is turned off.
If this issue has to be reported to the mod developer, let me know.
Copy from my comment on the PR:
This was actual intentional by me, not a bug. Made the parent not a lib and sorted the libs to under that, so config screens and versions can still be reached easily when libs are hidden, without cluttering the list with libs like on Forge/Neoforge that don't support that. I mean, this is probably something that can be argued about, but I assume this is a non-problematic solution?
I'm totally open to feedback here. If this is a major annoyance for some reason or a policy, then I can accept the prs and make the parent a lib too. My issue is, that down the line some of the libs are supposed to be normally reachable to change UI settings in TRender or in the future a diagnostics lib screen to better help identify issues in big modpacks. That was in my head the reasoning to not just seal away everything behind the libs toggle like with the fabric API, where nothing has options.
Configurable library mods are probably a debatable choice, but I've got no horse in this race. I don't know why folks are so heck-bent on hiding libraries anyway. Grouping though is indeed a very useful thing which makes the pain of this kind of situation a lot less.
In order for the Library badge to show up, they need to modify their Mod's Metadata to include it.
I think it's a fake mod (only exists because of being referred to as a parent). I'm not sure you can make a fake mod be a library. I think I tried to do that once, years ago.