Modonomicon

Modonomicon

1M Downloads

Recipe pages not rendering page text with 2 recipes set

DaFuqs opened this issue · 1 comments

commented

Describe the bug
When using the blasting recipe page like this:

{
  "type": "modonomicon:blasting_recipe",
  "title1": "book.spectrum.guidebook.pure_resources.page1.title",
  "recipe_id_1": "spectrum:blasting/pure_resources/iron",
  "recipe_id_2": "spectrum:blasting/pure_resources/gold",
  "text": "book.spectrum.guidebook.pure_resources.page1.text"
}

The recipes and title render, but not the page text.

This is because BookRecipePageRenderer only renders the text when there is no second recipe


but that is not reflected on the wiki.

Looking at a Blasting Recipe page with 2 recipes there is quite some more room which could fit some text. So maybe still rendering the text on the leftover space would be feasible.
image

Expected behavior

  1. the wiki being updated

OR

  1. the text rendering
commented

It is intended behaviour, but not apparently documented currently.

However, I designed this when doing the normal crafting page, which does not leave as much space. So I think it would be good to add text rendering, I just need to check if that can be done backwards compatible with addon pages (I believe the text offsets on recipe pages need an override in child classes)