Modonomicon

Modonomicon

29M Downloads

Modonomicon + Spectrum glitch

Closed this issue · 12 comments

commented

While using the documentation book for Spectrum, each entry opens but the menu remains visible on top of the entry, making parts difficult or impossible to read.

Steps to reproduce the behavior:

  1. Have Spectrum and Modonomicon installed
  2. Open the Spectrum book "Colorful World"
  3. Click on any unlocked entry
  4. The menu icons remain overlapping the entry screen

The entry screen that opens should be on top of the menu icons, not below it.

Image
  • Modonomicon Version: 1.115.1 Fabric
  • OS: Windows
  • Minecraft Version: 1.21.1
  • Modpack Link and Version, or list of mods:
    https://pastebin.com/ekQH8UBH
commented

@ivorycatdragon is there any way to reproduce this with another mod using modonomicon?
I fail to reproduce it with modnomicon and it's demo book

commented

@ivorycatdragon is there any way to reproduce this with another mod using modonomicon? I fail to reproduce it with modnomicon and it's demo book

Not afaik. It only happens to us with Spectrum, as its the only mod we have which uses modonomicon that I know of. It might be worth looking into though, especially if you can't reproduce the bug with the parameters provided. What other mods use Modonomicon? Are they in the list I provided?

commented

@ivorycatdragon I did not see any in the list that I now of (but I do not know all that use it). Could you potentially add theurgy or occultism to a test run of your modpack and see if the books for them work?
I am testing with spectrum now to see if it reproduces with no other mods present

Spectrum alone seems to work without this issue:

Image
commented

Most likely this means that there is a mod that either modifies how other mods render OR that renders something to screen without cleaning up the render matrix stack (OR modonomicon is not doing a required cleanup somewhere before rendering).

To solve this we would need to know which mod on the list causes the issue.
Are you familiar with the binary search principle to narrow down which mod causes an issue?
@ivorycatdragon

commented

Most likely this means that there is a mod that either modifies how other mods render OR that renders something to screen without cleaning up the render matrix stack (OR modonomicon is not doing a required cleanup somewhere before rendering).

To solve this we would need to know which mod on the list causes the issue. Are you familiar with the binary search principle to narrow down which mod causes an issue? @ivorycatdragon

I am familiar with that method, but that would need to wait as I'm currently busy. My friend is currently doing some testing in the meantime. Occultism and Theurgy aren't available for our game version and modloader (We're on fabric). So we can't try it out with that.

commented

Most likely this means that there is a mod that either modifies how other mods render OR that renders something to screen without cleaning up the render matrix stack (OR modonomicon is not doing a required cleanup somewhere before rendering).

To solve this we would need to know which mod on the list causes the issue. Are you familiar with the binary search principle to narrow down which mod causes an issue? @ivorycatdragon

Update: Friend used the binary search principle and narrowed it down to the library mod Balm, or potentially at least the mods which relies upon it which includes Waystones and lots of other mods we rely on. Any ideas as to why that is, and how to fix it? Removing the mod is not an option, too much of our stuff rely on it to function.

commented

@ivorycatdragon that is a good start, thank you!
Is there any way to narrow it down further?
As in, could you leave balm in and remove the mods relying on it one by one, such as waystone?

Just to figure out if it is balm itself, or one of the mods using balm.

If we know the exact mod we can get in touch with the mod author and see on which end we need to make changes

commented

@ivorycatdragon that is a good start, thank you! Is there any way to narrow it down further? As in, could you leave balm in and remove the mods relying on it one by one, such as waystone?

Just to figure out if it is balm itself, or one of the mods using balm.

If we know the exact mod we can get in touch with the mod author and see on which end we need to make changes

Ok we have hit a snag again. It seems the search was unsuccessful. When testing the game with just balm the bug was gone, so we added mods which seemed to use it one by one. My friend came to the conclusion that it was the mod regrowth. But there is a small problem with that: In his pack, it was already disabled during testing cause we found it interfered with stuff in our playthrough.
And I don't even have the mod installed, yet for me the bug persists no matter what I disable related to balm. So now we're wondering if the search misfired

commented

@ivorycatdragon minecraft never makes it easy - keep me posted if you can find anything! Once we have a culprit I can jump in and hopefully find out what is going on and how to fix it

commented

@klikli-dev ok! I think we found the culprit: Blur+. Try installing that and see if it creates the bug for you

commented

@ivorycatdragon thanks a lot, the issue reproduces with the mod! I will take a look at it and see if I can find a solution or need to get in touch with the author

commented

Ok a quick review of the issue site of Blur+ shows that this is an issue they have with various mods that render multiple screen layers.

The issue Motschen/Blur#109 has comments that show some additional affected mods.

Looks like the dev is investigating, but does not have a solution yet.

Considering this I will close this issue, but please ping me to reopen it if the discussion on Blur comes to the conclusion that the affected mods need to somehow communicate with blur to allow them to fix it.