ModTweaker

ModTweaker

88M Downloads

Tinkers Construct support does not make use of the new API

KnightMiner opened this issue ยท 4 comments

commented

Other than casting recipes, it seems the Tinkers Construct support is still acting based on the old API, thus a few unneeded things still exist:

  • Display item can be anything now, it does not have to be a block. Since the parameter does absolutly nothing in the code right now, there is no need to error and skip the recipe there
  • Temperature can either be provided or inferred from the liquid amount and temperature. As it is right now, it is inferring it, while the temp parameter does nothing (should be made @optional instead)
  • Inputs support oredictionary natively. This is true for both the smeltery and the drying rack

ModTweaker version 2.0.7 for 1.10.2 if it helps, though any 1.10.2 version is affected.

commented

Which TiC version has the new api?

commented

All of TiC 2, so Minecraft 1.8+ versions of Tinkers. You are calling the new API, but still acting as though you are using the old one (so you have the unused display block parameter and never pass along the temperature, along with handling oredictionary inputs yourself instead of passing them along)

commented

Could this issue be why my script won't work?

Edited out due to below request , moved to issue #421

commented

@Flabort make your own issue. and follow the template please