Getting null when removing Blood Magic Alchemy recipe

Question

Getting null when removing Blood Magic Alchemy recipe

elwooha6 opened this issue 8 years ago · 14 comments

elwooha6 commented 8 years ago

Issue Description:

When removing a recipe from Blood Magics Alchemy Table I get an NPE in minetweaker log. No error occurs when adding a new recipe.

What happens:

I get an error in chat.

What you expected to happen:

Scripts to reload and recipe to be removed.

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue): https://pastebin.com/tFqbJpNN

Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue): https://pastebin.com/4sR9Q14M

Affected Versions (Do not use "latest"):

Minecraft: 1.10.2
Forge: 12.18.3.2254
Crafttweaker: 3.0.24
ModTweaker: 2.0.11
MTLib: 1.0.2

Your most recent log file where the issue was present:

https://pastebin.com/dxmieEKY

JolyGoodDay commented 8 years ago

ahh

JolyGoodDay · Answer 1 · 2017-04-02T05:16:19.000Z

same issue,

reload never works and seems to just add all recipes back and sometimes multiples of your new one if you add it.

Restarting the whole game will load all the changes you made correctly.

JolyGoodDay · Answer 2 · 2017-04-02T05:51:08.000Z

Change to version 2.0.6

jaredlll08 · Answer 3 · 2017-04-02T13:51:29.000Z

Want, so does this work perfectly without reloading?

…

On Apr 2, 2017 7:51 AM, "JolyGoodDay" ***@***.***> wrote: Change to version 2.0.6 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#454 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFS9xf_-oUw8pjqcTL90pKQHgoMgbuUSks5rrzdMgaJpZM4Mtz3r> .

JolyGoodDay · Answer 4 · 2017-04-02T21:33:27.000Z

Latest version as per yesterday has a null error occur when you run "/minetweaker reload". The recipes will load from start up correctly from what I could tell, its just after a reload that messes everything up.

Version 2.0.6 works fine, I tired this version specifically after consulting a popular mod pack author.

Please let me know if you need video with explanation, i can make one quickly after I get home. I did not do any extensive tests, and I used the curse launcher.

jaredlll08 · Answer 5 · 2017-04-02T21:38:56.000Z

I can help if you are reloading.

…

On Apr 2, 2017 11:33 PM, "JolyGoodDay" ***@***.***> wrote: Latest version as per yesterday has a null error occur when you run "/minetweaker reload". The recipes will load from start up correctly from what I could tell, its just after a reload that messes everything up. Version 2.0.6 works fine, I tired this version specifically after consulting a popular mod pack author. Please let me know if you need video with explanation, i can make one quickly after I get home. I did not do any extensive tests, and I used the curse launcher. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#454 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFS9xckA8St08eEh0H6tM-0Ht4gOruzmks5rsBQngaJpZM4Mtz3r> .

JolyGoodDay · Answer 6 · 2017-04-02T22:15:17.000Z

What do you mean?

bookerthegeek · Answer 7 · 2017-04-02T22:17:44.000Z

Can't help.

jaredlll08 · Answer 8 · 2017-04-02T22:20:01.000Z

I mean, if the error cannot be replicated without running mt reload, then I won't even try fix it.

…

On Apr 3, 2017 12:17 AM, "BookerTheGeek" ***@***.***> wrote: Can't help. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#454 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFS9xU8dU89CVBtaTd2U-Wvqjz877baPks5rsB6IgaJpZM4Mtz3r> .

JolyGoodDay · Answer 9 · 2017-04-02T22:31:29.000Z

The thing is reload works just fine with older version of mod tweaker.

jaredlll08 · Answer 10 · 2017-04-02T22:45:03.000Z

Regardless. If it can't be reproduced without a reload, then I don't support it.

…

On Apr 3, 2017 12:31 AM, "JolyGoodDay" ***@***.***> wrote: The thing is reload works just fine with older version of mod tweaker. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#454 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFS9xe8lw60Fb_InCoWU2JuLEcgZum7Tks5rsCHCgaJpZM4Mtz3r> .

elwooha6 · Answer 11 · 2017-04-03T01:27:20.000Z

How about an answer to the OP, this guy just came along and hijacked my issue.

JolyGoodDay · Answer 12 · 2017-04-03T01:40:52.000Z

Changing from version 2.0.8 to 2.0.9 is where I find the issue to take place. Saying you don't support your own mod is silly.

Script used:

recipes.remove(bloodmagic:BlockAltar);
recipes.addShaped(bloodmagic:BlockAltar,
[[botania:quartzTypeDark:2,null,botania:quartzTypeDark:2],
[botania:quartzTypeDark:1,botania:rune:1,botania:quartzTypeDark:1],
[avaritiaadditions:endest_pearl,bloodmagic:ItemMonsterSoul,avaritiaadditions:endest_pearl]]);

Picture after reload

https://puu.sh/v7r7F/365c83e07f.png

I literally can not use versions of your mod after 2.0.8 due to this, it takes to long to restart the entire game every time I want to check to make sure I did a recipe correctly.

NOTE: it also breaks the reload and other modded items recipes do not show up.

bookerthegeek · Answer 13 · 2017-04-03T02:45:22.000Z

@elwooha6 I'll try to reproduce tonight an see.

@JolyGoodDay Reload has NEVER been supported. IIRC it was added for minetweaker for vanilla recipies only. Even then the only official answer is "/mt reload is not supported for bugs or issues" Dont like it? Then dont use the mod or make your own.

Share to