ModTweaker

Issue Description:

I made a script to add several liquids as smeltery fuels, but no matter the temperature I set, the smeltery says "Not enough heat to melt this item". I've tried about 15 different numbers between 300 and 240000.

What happens:

The smeltery doesn't smelt anything, when supplied with the newly added fluids.

What you expected to happen:

I expected the smeltery to smelt items, when supplied with Refined Fuel among others.

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):

https://gist.github.com/NillerMedDild/143b18260c96a51b53a25e07089d9d90

Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):

https://gist.github.com/NillerMedDild/dcb30a5c928cd5407cc6883d0086779e

Affected Versions (Do not use "latest"):

Minecraft: 1.12.2
Forge: 1.12.2-14.23.0.2515
Crafttweaker: CraftTweaker2-1.12-4.0.8
ModTweaker: modtweaker-4.0.4
MTLib: MTLib-3.0.1

Your most recent log file where the issue was present:

https://gist.github.com/NillerMedDild/e26b7b1cd53ecac4ae8d163d04fdebb5

According to the log everything is being parsed correctly.
Might be a change in their API since MoT zs implementation.

ModTweaker/src/main/java/com/blamejared/compat/tconstruct/Fuel.java

Lines 35 to 39 in 2f195bc

    
           public Add(FluidStack fuel, int temp) { 
        
               super("Fuel"); 
        
               this.fuel = fuel; 
        
               this.duration = temp; 
        
           }

The provided temperature int is NOT for the actual smelting temperature but for the time a fluid stack lasts as fuel:

https://github.com/SlimeKnights/TinkersConstruct/blob/7e2199c58766b858ac2f3c6c6067e8a90da2ca7d/src/main/java/slimeknights/tconstruct/library/TinkerRegistry.java#L646-L665

EDIT: The temperature depends on the fluid registry temperature
EDIT2: Check the ILiquidDefinition Crafttweaker wiki page: Maybe that works?

Thanks a lot for the clarification, I'll try changing the temperature.

@kindlich

As @kindlich said, you don't set the temp with this command

That did the trick, thanks :D

Could you elaborate on what the temperature/duration sets? Amount of items smelted with 1mb?

http://crafttwaeker-docu.readthedocs.io/en/latest/#Mods/Modtweaker/TConstruct/Fuel/

Okay, so here's how it works:
The fluid amount you added to your fluidStack object is how many millibuckets the smeltery will drain at once to fuel itself.
The duration you used as second parameter determines for how many ticks these millibuckets will last.

Example:
mods.tconstruct.Fuel.registerFuel(<liquid:water> * 2, 300);
→ The smeltery will drain 2mB water whenever it needs to, never less.
→ Those 2mB of water will last for 300 ticks

So, in this case, every 300 ticks you'd need to have at least 2mB of water in the smeltery to keep it running constantly. At least that's what I think it's like 😉

Ah alright. Thanks for updating the documentation so fast :D

	public Add(FluidStack fuel, int temp) {
	super("Fuel");
	this.fuel = fuel;
	this.duration = temp;
	}

Share to