Removing Alloys causes script error during /mt reload
UndeadZeratul opened this issue ยท 17 comments
I mentioned this in #17 (comment), but when I try to remove an alloy recipe, it both doesn't remove the original recipe, as well as after doing a /mt reload, throws a null pointer exception. Just as bad, after I do a /mt reload, the new recipe doesn't even show up because the script breaks.
I and a friend are having the same problem. Java reports an error with the .zs-file followed by a stack trace from a null pointer exception. We are also trying to remove an alloy from TConstruct using the line:
mods.tconstruct.Smeltery.removeAlloy(<liquid:angmallen.molten>);
The error occurs when we run /mt reload
. The main difference is that we're not trying to add the alloy back. But I thought I'd report it here since we're also failing at removing an alloy. We're using version 2.0.6, latest release.
@froghouse could you test it with the latest version?
So the new version doesn't throw the error anymore, but it's also not removing the alloys correctly. The initial load still shows the old and new recipes, but when I do a /mt reload, it doesn't error, but then only has the original alloy recipe, rather than the new one.
@jaredlll08 shall look into it.
Oh, has it been possibly fixed? Sure, you can go ahead and test it if you'd like, otherwise if I have some free time I'll see what I can find.
In the rewritten version it doesn't throw a null pointer anymore, however, it does nothing. With the script from the wiki I cannot remove Manyullin's alloy recipe. @jaredlll08 !
We actually pulled down the latest from GitHub and built it manually since we don't have access to the jenkins. The build was from about a day or so ago.
@jaredlll08 you never made a commit anywhere, how is it fixed?
I thought I fixed it. I am suspecting it is a problem with the script HOWEVER I did insert a check to make sure that the liquid being removed actually exists
The original issue of the removeMelting() method call seems to be working fine now, but now I'm having an issue on the removeAlloy() method call; if that clarifies anything.
EDIT: If you'd like, here are the lines I'm having a problem with. When they're not commented out, the initial load results in having two alloy recipes, the original and my newly added one, for each of the 3 alloys. When I do a "/mt reload", I get a "ERROR: NEB2 TiC Tweaks.zs: null" message in chat, a null pointer exception on the alloy removal handler, and thus because the script fails, the original alloy recipes are still enabled, but my newly added ones are no longer there. Any subsequent attempts to do a "/me reload" result in the same outcome.
The problem was, you had to use the EXACT fluid amount, for example:
mods.tconstruct.Smeltery.removeAlloy(liquid:manyullyn.molten*16);