It would be nice to add runic shielding to additional items. Maybe you could add that functionality to modtweaker 0.7!

@jaredlll08 which interface adds the vis discount btw?

@hron84 it's called "IRunicArmor"

Once again though, not implementable unless you wanna ASM it in. Wouldn't recommend that. Tends to blow up.

I will not allow ASM into modtweaker at this stage. It can lead to very weird crash reports and can break compatability with newer forge versions or even newer mod versions

ASM is always the last option to /anything/. It's unavoidable for a few situations, but even in those: Small doses and only modification of output values. Never replace an entire class or method, because anyone else who might have wanted to hook or modify there will clash.

@BluSunrize Is it not a part of the Thaumcraft API? As I see IRunicArmor and IVisDiscountGear is a part of the TC4 API, I can't see why I would need ASM for it. Also Botania can migrate Runic Shielding properties from the Revealing stuff because it is stored as an NBT data.

Wow @hron84 that is like saying, "USB type C is part of the USB family! so it WILL work with USB Type B", hint, it will not. If you knew how to create a mod, then yes, you could create a CUSTOM item (as in the item is something that is added by your mod), then you would not need ASM. But using modtweaker, we cannot change a whole class structure especially at runtime.

@jaredlll08 my question was totally out of scope for MT. I just asked here because I do plan to make a small mod around TC, but I could not figure out which class/interface I need for Vis discount. I examined Botania source, but it does not add vis discount for mana/terrasteel helmet of revealing.

Thanks.

@hron84 Few things...

1. Specify that.
2. This is the MT github, we are not even expected to answer your question as it has nothing to do with MT
3. Keep your questions to the mod specific github / irc channel (#Thaumcraft)
4. It is simple:

public class ItemRep extends Item implements IVisDiscountGear

that is it.

Without giving any context it is annoying though, both Blu And I thought he
was talking about MT
On Apr 10, 2016 9:14 AM, "Yulife" [email protected] wrote:

Jared don't be so grumpy, that guy can ASK :P

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#62 (comment)

Jared don't be so grumpy, that guy can ASK :P

That would be possible via "IRunic".

Sorry, it is not possible. Due to Jared being lazy and it being an interface, nothing can be done about it :(

Thank you!
If there's an API for vis discount, please add that too!

IRunic is an interface, you have to implement IRunic in the actual class, that is why it is not possible